feat: add toggleable recording preferences with persistence#19
Open
rogerb831 wants to merge 3 commits intolukasbach:mainfrom
Open
feat: add toggleable recording preferences with persistence#19rogerb831 wants to merge 3 commits intolukasbach:mainfrom
rogerb831 wants to merge 3 commits intolukasbach:mainfrom
Conversation
- Set microphone recording checkbox to be checked by default when starting a new recording - Added placeholder microphone in initial state to ensure checkbox is checked - Updated useEffect to replace placeholder with actual default microphone when available - Improves user experience by reducing steps needed to start recording with microphone
- Add defaultRecordScreenAudio and defaultRecordMicrophone settings - Connect recorder state to settings for persistence across app restarts - Remove restrictions preventing unchecking both recording options - Initialize recorder with user's saved preferences on startup - Both checkboxes are now fully toggleable and state persists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds toggleable recording preferences with persistence across app restarts.
Changes
defaultRecordScreenAudioanddefaultRecordMicrophoneto control default recording behaviorBenefits
Testing