sanitize filesystem strings before terminal output#1205
Open
curious-rabbit wants to merge 3 commits intolsd-rs:mainfrom
Open
sanitize filesystem strings before terminal output#1205curious-rabbit wants to merge 3 commits intolsd-rs:mainfrom
curious-rabbit wants to merge 3 commits intolsd-rs:mainfrom
Conversation
Attacker-controlled filenames, symlink targets and paths could inject ANSI sequences when lsd rendered them to stdout or stderr. Adds a sanitize_for_terminal helper and a SafePath display wrapper in a new display_util module. Applies them to symlink rendering, folder header output, error messages and the name escape path. Also covers bidi formatting characters used for filename spoofing
added 2 commits
May 6, 2026 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attacker-controlled filenames, symlink targets and paths could inject ANSI sequences when lsd rendered them to stdout or stderr.
Adds a sanitize_for_terminal helper and a SafePath display wrapper in a new display_util module. Applies them to symlink rendering, folder header output, error messages and the name escape path. Also covers bidi formatting characters used for filename spoofing
Update:
The patch now also sanitizes xattr contexts and replaces two panic sites for non-utf8 symlink targets and non-utf8 filennames in git status that were reachable via filesystem input.