Tutorial groups: migrate tutorial group REST responses to DTOs#12562
Draft
WoH wants to merge 1 commit intols1intum:developfrom
Draft
Tutorial groups: migrate tutorial group REST responses to DTOs#12562WoH wants to merge 1 commit intols1intum:developfrom
WoH wants to merge 1 commit intols1intum:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate tutorial group list and free period REST responses away from entities to dedicated DTOs and enforce zero DTO architecture violations in the tutorial group module.
Checklist
General
Server
Motivation and Context
The tutorial group module still returned JPA entities directly from several REST endpoints and still allowed remaining entity-usage architecture violations. This PR completes the tutorial group backend migration for the affected list and free period responses and updates the architecture test to enforce zero remaining violations.
Description
TutorialGroupSummaryDTOforGET /api/tutorialgroup/courses/{courseId}/tutorial-groupsTutorialGroupFreePeriodDTOfor tutorial group free period read/create/update responsesTutorialGroupUpdateDTOZoneId, which removes the last remaining entity return violation inside the tutorial group REST controllersGET /courses/{id}/tutorial-groupsuse the flat fields and do not depend on nestedteachingAssistant,course, orregistrationsfrom that responseSteps for Testing
Prerequisites:
Course Administration->Tutorial groupsfor the prepared course.GET /api/tutorialgroup/courses/{courseId}/tutorial-groups.teachingAssistant,course, orregistrations.numberOfRegisteredUsers,teachingAssistantName,teachingAssistantId, andcourseTitle.GET /api/tutorialgroup/courses/{courseId}/tutorial-groupsresponse.GET /api/tutorialgroup/courses/{courseId}/tutorial-groupsresponse as the student and verify that the response still uses the flat DTO shape and that the private-information fields are hidden for all groups.Testserver States
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Performance Tests
Test Coverage