[alert,dv] Make the base driver explicit that it's just for alerts#29536
Draft
rswarbrick wants to merge 2 commits intolowRISC:masterfrom
Draft
[alert,dv] Make the base driver explicit that it's just for alerts#29536rswarbrick wants to merge 2 commits intolowRISC:masterfrom
rswarbrick wants to merge 2 commits intolowRISC:masterfrom
Conversation
rswarbrick
added
Component:DV
The two types of interface are pretty unrelated and the existing code had some strange corners. Make things more explicit and change esc_receiver_driver and esc_sender_driver to derive directly from dv_base_driver instead of alert_esc_base_driver. Signed-off-by: Rupert Swarbrick <[email protected]>
This was already the case (because the esc_*_driver subclasses didn't actually use the code in alert_esc_base_driver), but it was a little tricky to understand. Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
force-pushed
the
alert-base-driver-specificity
branch
from
a60b93f to
08eb66e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is in draft because it depends on #29504 (the first commit). Once that is merged, this PR only contains the final commit
This was already the case (because the
esc_*_driversubclasses didn't actually use the code inalert_esc_base_driver), but it was a little tricky to understand.