Skip to content

[entropy_src/doc] Clarify purpose of CONF.THRESHOLD_SCOPE field#29265

Merged
vogelpi merged 2 commits intolowRISC:masterfrom
vogelpi:es-doc
Feb 6, 2026
Merged

[entropy_src/doc] Clarify purpose of CONF.THRESHOLD_SCOPE field#29265
vogelpi merged 2 commits intolowRISC:masterfrom
vogelpi:es-doc

Conversation

@vogelpi
Copy link
Contributor

@vogelpi vogelpi commented Feb 5, 2026

No description provided.

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
@vogelpi vogelpi added the CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0 label Feb 5, 2026
@vogelpi
Copy link
Contributor Author

vogelpi commented Feb 5, 2026

CHANGE AUTHORIZED: hw/ip/entropy_src/data/entropy_src.hjson

This is just a documentation change.

@vogelpi vogelpi requested a review from nasahlpa February 6, 2026 09:37
Copy link
Member

@nasahlpa nasahlpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pirmin, just one nit.

@nasahlpa
Copy link
Member

nasahlpa commented Feb 6, 2026

CHANGE AUTHORIZED: hw/ip/entropy_src/data/entropy_src.hjson

This is just a documentation change.

@vogelpi vogelpi added the CI:Rerun Rerun failed CI jobs label Feb 6, 2026
@github-actions github-actions bot removed the CI:Rerun Rerun failed CI jobs label Feb 6, 2026
@vogelpi vogelpi added the CI:Rerun Rerun failed CI jobs label Feb 6, 2026
@github-actions github-actions bot removed the CI:Rerun Rerun failed CI jobs label Feb 6, 2026
The Repetition Count Test and the Adaptive Proportion Test are both
defined by the NIST SP 800-90B spec and to emphasize this, this commit
aligns the spelling of thesee two test names across the documentation
and RTL comments.

In contrast, the bucket and Markov tests are custom tests.

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
@vogelpi vogelpi requested a review from a team as a code owner February 6, 2026 15:15
@vogelpi vogelpi requested review from rswarbrick and removed request for a team February 6, 2026 15:15
@vogelpi
Copy link
Contributor Author

vogelpi commented Feb 6, 2026

CHANGE AUTHORIZED: hw/ip/entropy_src/rtl/entropy_src_adaptp_ht.sv
CHANGE AUTHORIZED: hw/ip/entropy_src/rtl/entropy_src_core.sv
CHANGE AUTHORIZED: hw/ip/entropy_src/rtl/entropy_src_repcnt_ht.sv
CHANGE AUTHORIZED: hw/ip/entropy_src/rtl/entropy_src_repcnts_ht.sv

The second commit changes the spelling of test names without introducing functional changes.

@nasahlpa
Copy link
Member

nasahlpa commented Feb 6, 2026

CHANGE AUTHORIZED: hw/ip/entropy_src/rtl/entropy_src_adaptp_ht.sv
CHANGE AUTHORIZED: hw/ip/entropy_src/rtl/entropy_src_core.sv
CHANGE AUTHORIZED: hw/ip/entropy_src/rtl/entropy_src_repcnt_ht.sv
CHANGE AUTHORIZED: hw/ip/entropy_src/rtl/entropy_src_repcnts_ht.sv

@vogelpi vogelpi added the CI:Rerun Rerun failed CI jobs label Feb 6, 2026
@github-actions github-actions bot removed the CI:Rerun Rerun failed CI jobs label Feb 6, 2026
@vogelpi vogelpi added this pull request to the merge queue Feb 6, 2026
Merged via the queue into lowRISC:master with commit e0d3422 Feb 6, 2026
47 of 49 checks passed
@lowrisc-ci
Copy link

lowrisc-ci bot commented Feb 6, 2026

Backport failed for earlgrey_1.0.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-29265-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-29265-to-earlgrey_1.0.0
git switch --create backport-29265-to-earlgrey_1.0.0
git cherry-pick -x ab8a16894b19fff0d51db083401a378a85514547 bac0b1b6d1d11c1a062c97eb382126d01fb853e9

@lowrisc-ci lowrisc-ci bot added the Manually CherryPick This PR should be manually cherry picked. label Feb 6, 2026
@lowrisc-ci
Copy link

lowrisc-ci bot commented Feb 6, 2026

Backport failed for earlgrey_1.0.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-29265-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-29265-to-earlgrey_1.0.0
git switch --create backport-29265-to-earlgrey_1.0.0
git cherry-pick -x ab8a16894b19fff0d51db083401a378a85514547 bac0b1b6d1d11c1a062c97eb382126d01fb853e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0 Manually CherryPick This PR should be manually cherry picked.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants