textCite#69
Open
fmatter wants to merge 3 commits intoloup-brun:masterfrom
Open
Conversation
added 3 commits
August 9, 2023 08:51
Author
|
@loup-brun any reaction to this? I've successfully been using my fork, see here for an example of the textCite output (I mean it's really just about putting the parentheses around the year instead of the entire citation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented a textCite argument to allow citations like "Name (year)" instead of only "(Name, year)". It can also be called with a trailing dash (parallel to the suppression of the author name by the leading dash).
Most other changes are cosmetic (indentation), but I realized that the entire loop was only run if no
IsNamedParamswas false, so usingkey="blabla"did not work at all. It does now.