Fix orphaned in_progress jobs after worker crash/restart#59
Open
Manuscrit wants to merge 1 commit intolongtermrisk:v0.9from
Open
Fix orphaned in_progress jobs after worker crash/restart#59Manuscrit wants to merge 1 commit intolongtermrisk:v0.9from
Manuscrit wants to merge 1 commit intolongtermrisk:v0.9from
Conversation
When a worker pod crashes (OOM, SIGKILL, power loss), the atexit shutdown handler never fires, leaving jobs stuck in in_progress status. If the pod restarts quickly with the same worker_id, the cluster manager's unresponsive-worker cleanup never triggers either (the worker keeps pinging). This causes orphaned jobs to accumulate — each crash leaves one more zombie in_progress job that no worker is executing. Fix: on startup, before entering the job loop, revert any in_progress jobs assigned to this worker_id back to pending. A freshly started worker process cannot be executing anything, so any such jobs are guaranteed orphans from a previous lifetime. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a worker pod crashes (OOM, SIGKILL, power loss), the atexit shutdown handler never fires, leaving jobs stuck in in_progress status. If the pod restarts quickly with the same worker_id, the cluster manager's unresponsive-worker cleanup never triggers either (the worker keeps pinging). This causes orphaned jobs to accumulate — each crash leaves one more zombie in_progress job that no worker is executing.
Fix: on startup, before entering the job loop, revert any in_progress jobs assigned to this worker_id back to pending. A freshly started worker process cannot be executing anything, so any such jobs are guaranteed orphans from a previous lifetime.