Conversation
It is not compiled yet. Write FunctionNode.C_fortran_generic to YAML files.
Repeated argument. Bad declaration.
Do not add the SWIG_MEM_OWN when the library owns the object. Compile getView test in cxxlibrary.yaml.
Do not need a C wrapper if the result is sgroup=shadow. A capsule is passed for both pointer shadow types. No changes in test suite, but a pending test will be impacted.
_PTR_F_C_index will always be set when C_fortran_generic was True, so just use that instead.
Better description of how it is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a fix to set cmemflags correctly in c_mixin_capsule_fill_cvar.