spack v1.0 support: %foo +bar -> +bar %foo#714
Open
haampie wants to merge 1 commit intollnl:haampie-spec-strfrom
Open
spack v1.0 support: %foo +bar -> +bar %foo#714haampie wants to merge 1 commit intollnl:haampie-spec-strfrom
%foo +bar -> +bar %foo#714haampie wants to merge 1 commit intollnl:haampie-spec-strfrom
Conversation
Spack v1.0 will parse `pkg %gcc +foo` as "pkg with direct dependency gcc with variant foo enabled" instead of "pkg with variant foo enabled and compiler gcc". Reorder as `pkg +foo %gcc` to be compatible with Spack v0.x and v1.0.
cnpetra
approved these changes
Mar 19, 2025
nychiang
approved these changes
Mar 21, 2025
Collaborator
|
does not pass one of the test, we need to look into it |
Collaborator
|
I changed the base to a new branch, and we are fine to merge this PR to that new branch. @haampie It would also be great if you could file this PR from the LLNL domain, without forking the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spack v1.0 will parse
pkg %gcc +fooas "pkg with direct dependency gccwith variant foo enabled" instead of "pkg with variant foo enabled and compiler
gcc". Reorder as
pkg +foo %gccto be compatible with Spack v0.x andv1.0.