Skip to content

fix delete activity #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KhetagAb merged 2 commits into from
Aug 21, 2025
Merged

fix delete activity #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed4dd1c
fix delete activity
mashashepp Aug 21, 2025
06c7b77
Merge branch 'master' into masha-bff-fix-activity
mashashepp Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bff/lkshmatch/adapters/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ async def create_activity(
async def delete_activity(
self,
requester_username: str,
core_id: CoreID,
activity_id: int,

) -> Activity:
raise NotImplementedError

Expand Down
4 changes: 2 additions & 2 deletions bff/lkshmatch/adapters/core/activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,11 @@ async def create_activity(
async def delete_activity(
self,
requester_username: str,
creator_id: int,
activity_id: int,
) -> Activity:
admin_token = self.privilege_checker.get_admin_token(requester_username)
response = await post_core_activity_delete_by_id.asyncio(
client=self.client, id=creator_id, privilege_token=admin_token
client=self.client, id=activity_id, privilege_token=admin_token
)
if isinstance(response, PostCoreActivityDeleteByIdResponse400):
raise InvalidParameters(
Expand Down