Draft
Conversation
* Don't create pub / sub trickle channels up front since those are now created on demand * Listen to the events channel for payments instead of pub channel
github-actions
bot
added
go
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3884 +/- ##
===================================================
- Coverage 32.79594% 32.54002% -0.25592%
===================================================
Files 171 172 +1
Lines 41993 42480 +487
===================================================
+ Hits 13772 13823 +51
- Misses 27189 27621 +432
- Partials 1032 1036 +4
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ai/worker/serverless_worker.go
Dismissed
| } | ||
|
|
||
| // Dial before starting goroutines so errors can be returned to caller | ||
| websocketConn, _, err := websocket.DefaultDialer.Dial(wsURL, headers) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in network request Critical
Collaborator
Author
There was a problem hiding this comment.
This is protected by an env var prefix: 5296840
If a client needs to start publishing again and doesn't know where
it left off, then it can add a Lp-Trickle-Reset header along with
the -1 seq ("write next empty segment") which is already supported.
This will unblock any subscribers that may be waiting for hanging
writes from the previous publisher.
Also add a Lp-Trickle-Seq header so publishers can correctly position
their next segment in the stream.
Fix a bookkeeping bug in the LocalPublisher, and add tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass