Skip to content

Ensure strict ordering of resolving waitForBufferStatus calls#1877

Open
lukasIO wants to merge 5 commits intomainfrom
lukas/simple-mutex
Open

Ensure strict ordering of resolving waitForBufferStatus calls#1877
lukasIO wants to merge 5 commits intomainfrom
lukas/simple-mutex

Conversation

@lukasIO
Copy link
Copy Markdown
Contributor

@lukasIO lukasIO commented Apr 9, 2026

No description provided.

@lukasIO lukasIO requested a review from 1egoman April 9, 2026 07:47
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 9, 2026

⚠️ No Changeset found

Latest commit: 3494d89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 95.53 KB (+0.11% 🔺)
dist/livekit-client.umd.js 104.35 KB (+0.1% 🔺)

@1egoman
Copy link
Copy Markdown
Contributor

1egoman commented Apr 9, 2026

@lukasIO As a heads up, I did some quick benchmarking and while this took about the same amount of time to run as my pull request, it results in a bit more of a variable delivery rate... I'm not exactly sure why though. The packet drops that occurred for in the context of both pull requests looked to generally be single packet drops for a data track frame.

This pull request:

Production:
Screenshot 2026-04-09 at 4 27 03 PM

Screenshot 2026-04-09 at 4 37 47 PM Screenshot 2026-04-09 at 4 39 13 PM

(I ran it ~10 times and forgot to take a screenshot, but saw one run go as low as a 20% delivery rate on the second low_fps_multi_packet test)

Staging:
Screenshot 2026-04-09 at 5 28 58 PM

Screenshot 2026-04-09 at 5 30 09 PM Screenshot 2026-04-09 at 5 31 35 PM

My pull request's current state (d1858ba), against production:

Screenshot 2026-04-09 at 4 41 12 PM Screenshot 2026-04-09 at 4 43 25 PM

Also for completeness, the below is my pull request pre introduction of the mutex (b7153a1) against production, which has roughly the same performance characteristics:

Screenshot 2026-04-09 at 4 46 50 PM Screenshot 2026-04-09 at 4 48 21 PM Screenshot 2026-04-09 at 4 50 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants