You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
@lukasIO As a heads up, I did some quick benchmarking and while this took about the same amount of time to run as my pull request, it results in a bit more of a variable delivery rate... I'm not exactly sure why though. The packet drops that occurred for in the context of both pull requests looked to generally be single packet drops for a data track frame.
This pull request:
Production:
(I ran it ~10 times and forgot to take a screenshot, but saw one run go as low as a 20% delivery rate on the second low_fps_multi_packet test)
Staging:
My pull request's current state (d1858ba), against production:
Also for completeness, the below is my pull request pre introduction of the mutex (b7153a1) against production, which has roughly the same performance characteristics:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.