Ensure leave requests can be sent before join response is received#1687
Merged
Ensure leave requests can be sent before join response is received#1687
Conversation
🦋 Changeset detectedLatest commit: 47492cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasIO
requested review from
1egoman and
boks1971
and removed request for
boks1971
Contributor
size-limit report 📦
|
lukasIO
commented
Oct 14, 2025
| } | ||
| }); | ||
|
|
||
| it('should set up stream writer from connection writable', () => { |
Contributor
Author
There was a problem hiding this comment.
deleting this as we're setting up the connection writable immediately on ws connection opened now
This was referenced Oct 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR ensures that on aborted connections we still send a LeaveRequest to the server (we could consider adding a new reason for this to not conflate
ClientInitiatedtoo much?).It also ensures that we don't have to wait for
joinResponseto be present for a leave request to be initiated by assigning the streamWriter immediately after the ws connection is opened