-
Notifications
You must be signed in to change notification settings - Fork 209
Gemini realtime thinking config #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: jason.wiker <[email protected]>
|
Cursor Agent can help with this pull request. Just |
🦋 Changeset detectedLatest commit: aee53c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Shubhrakanti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make an example and run it to make sure it works as intended.
| /** | ||
| * Thinking configuration for native audio models. | ||
| * Use `\{ thinkingBudget: 0 \}` to disable thinking. | ||
| * Use `\{ thinkingBudget: -1 \}` for automatic/dynamic thinking. | ||
| */ | ||
| thinkingConfig?: types.ThinkingConfig; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the default value if we send nothing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it's thinking mode by default
Co-authored-by: jason.wiker <[email protected]>
Description
Adds the
thinkingConfigparameter to the Gemini Realtime Model in the LiveKit agents-js SDK. This change aligns the JS SDK with the Python SDK, enabling users to configure the thinking behavior of native audio models (e.g., disable thinking or use dynamic thinking).Changes Made
thinkingConfig?: types.ThinkingConfigto theRealtimeOptionsinterface.thinkingConfig?: types.ThinkingConfigas a constructor parameter toRealtimeModelwith JSDoc documentation.thinkingConfiginthis._optionswithin theRealtimeModelconstructor.thinkingConfigthrough in thebuildConnectConfig()method at the top level of theLiveConnectConfigobject.Pre-Review Checklist
Testing
restaurant_agent.tsandrealtime_agent.tswork properly (for major changes)The AI performed linting and type-checking, and verified the specific code changes were correctly implemented.
Additional Notes
Usage example:
Note to reviewers: Please ensure the pre-review checklist is completed before starting your review.