ibstat: ignore non-RDMA endpoint devices when umad_get_ca() fails#1722
Open
NagappanRMPL wants to merge 1 commit intolinux-rdma:masterfrom
Open
ibstat: ignore non-RDMA endpoint devices when umad_get_ca() fails#1722NagappanRMPL wants to merge 1 commit intolinux-rdma:masterfrom
NagappanRMPL wants to merge 1 commit intolinux-rdma:masterfrom
Conversation
NagappanRMPL
force-pushed
the
master
branch
4 times, most recently
from
1544744 to
de2b9a2
Compare
Author
|
Hi, Could you please review the changes for ibstat command. Thanks, |
When umad_get_ca() fails, ibstat currently propagates the error even for devices that are not usable RDMA endpoints. Add lightweight sysfs checks to detect non-endpoint devices by verifying either the presence of port GID 0 (ports/<n>/gids/0) or the Connection Manager capability bit (port cap_mask bit 16). If neither is present, treat the device as non-RDMA and return 0 instead of failing. This improves behavior on systems exposing non-endpoint IB-class devices under /sys/class/infiniband/. Signed-off-by: Nagappan Ramasamy Palaniappan <nagappan.ramasamy.palaniappan@oracle.com>
Author
|
Hi @rleon , Could you please review this change for ibstat command. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orabug: 38502630
When umad_get_ca() fails, ibstat currently propagates the error even for devices that are not usable RDMA endpoints.
Add lightweight sysfs checks to detect non-endpoint devices by verifying either the presence of port GID 0 (ports//gids/0) or the Connection Manager capability bit (port cap_mask bit 16). If neither is present, treat the device as non-RDMA and return 0 instead of failing.
This improves behavior on systems exposing non-endpoint IB-class devices under /sys/class/infiniband/.