Update Helm chart, make RBAC optional, add Service#354
Open
multimac wants to merge 4 commits intolinki:masterfrom
Open
Update Helm chart, make RBAC optional, add Service#354multimac wants to merge 4 commits intolinki:masterfrom
multimac wants to merge 4 commits intolinki:masterfrom
Conversation
multimac
force-pushed
the
helm-chart-rbac-service
branch
from
5cd4eca to
ed1be6c
Compare
multimac
force-pushed
the
helm-chart-rbac-service
branch
from
ed1be6c to
dc6f940
Compare
multimac
force-pushed
the
helm-chart-rbac-service
branch
from
6d97949 to
c602fff
Compare
multimac
force-pushed
the
helm-chart-rbac-service
branch
from
c602fff to
f9070af
Compare
mkilchhofer
reviewed
Aug 9, 2021
mkilchhofer
left a comment
mkilchhofer
left a comment
There was a problem hiding this comment.
What about adding a ServiceMonitor as well?
|
|
||
| spec: | ||
| type: {{ .Values.chaoskube.metrics.service.type }} | ||
|
|
There was a problem hiding this comment.
Why adding blank lines here (L9, L12, L18)?
What about adding clusterIP: None by default (headless service)? Normally we don't need a ClusterIP for metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got some additional changes to the Helm chart for Chaoskube.
Changes
ClusterRoleandClusterRoleBindingoptional by settingrbac.createtofalseServicewhich can be created and configured viachaoskube.servicepodLabels