Send media and file by thuyenh1081 · Pull Request #2654 · linagora/twake-on-matrix

thuyenh1081 · 2025-11-06T04:38:04Z

Ticket

This ticket include code for sending a file, image, video in a chat

Resolved

Screen.Recording.2025-11-06.at.14.06.34.mov

Insalien · 2025-11-07T03:40:39Z

integration_test/help/attach_file_ios_test.dart

+   final titles = <Selector>[
+    Selector(textContains: 'Would Like to Access Your Photo Library'),
+    Selector(textContains: 'muốn truy cập Ảnh'),
+    Selector(textContains: 'Thư viện ảnh'),


Why there is a mix of English and Vietnamese text here
It seems that we could we retrieve the label text directly from the code in other existing tests.

The text displayed depend on language that you setting for your mobile and for some case that could be displayed like this

So Patrol could not force the default langage of the application to English to simplify the test or any similar mechanism?

This popup is not control by Tchat app. It is belogn navive device, I means mobile devices.
I think Patrol is a framework provides us library that helping interact with elements on mobile. If you want to control Patrol do it, you must do some action like, to go setting, choose language for the mobile device. it will take time more the way you list the text that can be displayed on some language. It will be easier and faster way

why not base on Id, class name, or anything else? it is not idea. How about if it is French, Russian, ....

@Insalien @hoangdat
I have updated the way to click on the Popup in the last commit. It will not depends on language
In this way:

I use index to click on button "Allow Photo" button. PHPhotoLibrary is a system popup and we cannot use flutter inspector in inspect element on it. So, it is difficult to know what is id or class of Allow Button. Patrol document https://patrol.leancode.co/feature-guide/pick-images-from-gallery guide using await $.native2.grantPermissionWhenInUse(); to click on Allow button but this method actually base on language in English. https://github.com/leancodepl/patrol/discussions/563?utm_source=chatgpt.com That is why I choose index. Each approach has its own risks, but I think using the index is acceptable in this case because the UI of this type of popup is rarely changed.

Insalien · 2025-11-07T03:40:57Z

integration_test/help/attach_file_ios_test.dart

+    Selector(textContains: 'Cho phép'),
+    Selector(textContains: 'Toàn bộ ảnh'),
+  ];
+


Same as above

The text displayed depend on language that you setting for your mobile and for some case that could be displayed like this.

@Insalien , I have updated with the way not depend on language, thanks!

Insalien · 2025-11-07T03:45:06Z

integration_test/help/attach_file_ios_test.dart

+        await $.native.waitUntilVisible(t, appId: _sb, timeout: const Duration(milliseconds: 300));
+        stillVisible = true; 
+        break;
+      } catch (_) {


why we have try catch here

this snipe code belongs allowPhotosIfNeeded(). This method is used to click on the Photo access popup but the popup just display 1 time in the running. It means in other uploading steps in the scrips, the popup will not be shown. The spring board of popup will not shown also. So, I make try cache to ignore this case

Insalien · 2025-11-07T03:45:23Z

integration_test/help/attach_file_ios_test.dart

+      await $.native.waitUntilVisible(t, appId: _sb, timeout: const Duration(seconds: 6));
+      visible = true;
+      break;
+    } catch (_) {}


why we have try catch here

this snipe code belongs allowPhotosIfNeeded(). This method is used to click on the Photo access popup but the popup just display 1 time in the running. It means in other uploading steps in the scrips, the popup will not be shown. The title of popup will not shown also. So, I make try cache to ignore this case

hoangdat · 2025-11-07T05:34:52Z

integration_test/data/PndFile1.png

too big file, how about using smaller one?

yes, I have replaced it by a smaller one

hoangdat · 2025-11-07T05:34:57Z

integration_test/data/MovVideo1.mov

yes, I have replaced it by a smaller one

…per.dart

hoangdat · 2025-11-11T08:29:30Z

integration_test/help/attach_file_ios_helper.dart

+  catch (_) {}
+}
+
+Future<void> maybeTapFirstV1(PatrolIntegrationTester $, List<Selector> opts) async {


what is FirstV1?

hoangdat · 2025-11-11T08:29:50Z

integration_test/help/attach_file_ios_helper.dart

+}
+
+Future<void> maybeTapFirstV1(PatrolIntegrationTester $, List<Selector> opts) async {
+  for (final s in opts) { try { await $.native.tap(s); return; } catch (_) {} }


please not write like it

hoangdat · 2025-11-11T08:32:12Z

scripts/integration_test_patrol.sh

+set -e
+
+# --- Config --------------------------------------------------------------
+UDID="DDDF0F2B-507B-43EE-AE0B-CABF4ED25D1F"   


no hardcode this, how about other people run the tests

hoangdat · 2025-11-11T08:35:42Z

scripts/integration_test_patrol.sh

if you change the file like this, this will break test for Android.
Please separate script for iOS and Android or find other way to support all platform.

hoangdat · 2025-11-11T08:53:59Z

integration_test/robots/chat_group_detail_robot.dart

  }

+  PatrolFinder getMoreMessageIcon() {
+    return $(ChatInputRow).$(TwakeIconButton).containing(find.byTooltip('More'));


no text selector

hoangdat · 2025-11-11T08:54:51Z

integration_test/robots/chat_group_detail_robot.dart

+    await getMoreMessageIcon().tap();
+    if($(PermissionTextButton).containing('Next').exists)
+    {
+      await $.waitUntilVisible($(PermissionTextButton).containing('Next'));


hoangdat · 2025-11-11T08:55:19Z

integration_test/robots/login_robot.dart

  }

  Future<void> confirmServerUrl() async {
+    await $.waitUntilVisible($('Continue'));


thuyenh1081 added 7 commits November 6, 2025 10:22

update data for file image video

946aef4

upload file into Download folder of simulator

6c80e6c

add the methods to open Attach dialog of simulator for uploading a file

e04ef3b

add the methods to upload a file from a chat

36f2e5e

get file, video, media on a chat

3a69d85

add script 'verify user can send a file, image, video'

d1aab33

declare file, image, video

b2b8958

thuyenh1081 requested a review from Insalien November 6, 2025 04:38

thuyenh1081 requested review from dab246, hoangdat, nqhhdev and tddang-linagora as code owners November 6, 2025 04:38

thuyenh1081 had a problem deploying to PR-2654 November 6, 2025 04:38 — with GitHub Actions Error

remove await when call getInputTextField

878c90b

thuyenh1081 had a problem deploying to PR-2654 November 6, 2025 04:50 — with GitHub Actions Failure

Insalien reviewed Nov 7, 2025

View reviewed changes

hoangdat reviewed Nov 7, 2025

View reviewed changes

thuyenh1081 added 8 commits November 8, 2025 10:44

wait before clicking on Continue

c65b91e

update method allowPhotosIfNeeded()

ffc9b96

update script 'verify user can send a file, image, video'

e0a99f1

remove unnecessary line code

c362305

replace the image with smaller one

97e198a

replace the image with smaller one

445a582

replace the image with smaller one

f38c6f9

change name of class attach_file_ios_test.dart to attach_file_ios_hel…

c519f93

…per.dart

hoangdat reviewed Nov 11, 2025

View reviewed changes

integration_test/robots/login_robot.dart

}

Future<void> confirmServerUrl() async {

await $.waitUntilVisible($('Continue'));

Copy link

Member

hoangdat Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

Conversation

thuyenh1081 commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ticket

Resolved

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thuyenh1081 Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thuyenh1081 Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thuyenh1081 Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thuyenh1081 Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thuyenh1081 commented Nov 6, 2025 •

edited

Loading

thuyenh1081 Nov 7, 2025 •

edited

Loading

thuyenh1081 Nov 7, 2025 •

edited

Loading

thuyenh1081 Nov 8, 2025 •

edited

Loading

thuyenh1081 Nov 8, 2025 •

edited

Loading