[PERF] Optimize REPORT requests by using batch MongoDB queries#141
Draft
[PERF] Optimize REPORT requests by using batch MongoDB queries#141
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes REPORT request performance by replacing sequential MongoDB queries with batch fetching. The main optimization leverages getMultipleCalendarObjects() to execute a single query with $in operator instead of N sequential queries when fetching calendar objects, with fallback support for nodes that don't implement batch fetching.
Key Changes:
- Implements batch fetching in
getMultipleDAVItems()usinggetMultipleCalendarObjects()when available - Adds fallback to sequential
getPropertiesForMultiplePathsfor nodes without batch support - Updates Docker Compose test configuration to add health checks for MongoDB and RabbitMQ
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/JSON/Plugin.php | Adds batch fetching logic with getMultipleCalendarObjects() and maintains fallback to sequential queries |
| docker-compose.test.yaml | Adds health check conditions to prevent test failures from unready dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
chibenwa
requested changes
Oct 21, 2025
Replace sequential getPropertiesForMultiplePaths calls with batch fetching using getMultipleCalendarObjects. This reduces REPORT request time significantly by executing a single MongoDB query with $in instead of N sequential queries. Changes: - Modified getMultipleDAVItems to use getMultipleCalendarObjects when available - Falls back to getPropertiesForMultiplePaths for nodes without batch support - Added healthcheck dependency to docker-compose.test.yaml for MongoDB and RabbitMQ Fixes #129 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…ventInfoForUser assignment
8a0cca1 to
bad5ac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
getPropertiesForMultiplePathscalls with batch fetching usinggetMultipleCalendarObjects$ininstead of N sequential queriesChanges
getMultipleDAVItems()inlib/JSON/Plugin.phpto usegetMultipleCalendarObjects()when availablegetPropertiesForMultiplePathsfor nodes without batch support (e.g., SharedCalendar)docker-compose.test.yamlfor MongoDB and RabbitMQ to prevent test failuresPerformance Impact
Before: N sequential MongoDB queries (one per calendar object)
After: 1 batch MongoDB query with
$inoperatorFor an agenda with 100 events in a time range, this reduces from 100 queries to 1 query.
Test plan
Fixes #129
🤖 Generated with Claude Code