[cmake] move cmake_minimum_required to first line#7210
Merged
Conversation
jameslamb
requested review from
StrikerRUS,
borchero,
jmoralez and
shiyu1994
as code owners
guolinke
approved these changes
Apr 1, 2026
Member
Author
|
Thanks for checking in on reviews @guolinke , there's a lot I'd like to do here and each step helps! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #6774
Moves
cmake_minimum_required()to the top ofCMakeLists.txt.As described in https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html, this call informs all of CMake's version-dependent behavior. It should always be the first statement in a
CMakeListst.txtfile.