[python-package] Add tests on Booster.eval() handling of new validation sets#7167
Merged
jameslamb merged 9 commits intolightgbm-org:masterfrom Apr 1, 2026
Merged
[python-package] Add tests on Booster.eval() handling of new validation sets#7167jameslamb merged 9 commits intolightgbm-org:masterfrom
jameslamb merged 9 commits intolightgbm-org:masterfrom
Conversation
daguirre11
requested review from
StrikerRUS,
borchero,
guolinke,
jameslamb,
jmoralez and
shiyu1994
as code owners
daguirre11
changed the title
31 tasks
jameslamb
changed the title
jameslamb
requested changes
Feb 27, 2026
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Thanks so much for doing this, it's great to have some more test coverage of this method!
Co-authored-by: James Lamb <jaylamb20@gmail.com>
jameslamb
approved these changes
Mar 22, 2026
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
If this passes CI I'll merge it, thanks so much for the help!
jameslamb
reviewed
Mar 22, 2026
Co-authored-by: James Lamb <jaylamb20@gmail.com>
jameslamb
reviewed
Mar 22, 2026
jameslamb
reviewed
Mar 23, 2026
Member
|
Sorry for the couple of bad commits I pushed here, I think everything's looking good now! The only remaining failing CI is the job we use to test against the latest nightly packages or If that isn't resolved upstream in a few days, we'll temporarily turn off that job so PRs like this one can move forwad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #7031
BEFORE
AFTER
2 line difference in coverage for
/lightgbm/basic.py