Change some PL/pgsql functions to SQL#2
Open
davidfetter wants to merge 1 commit intoleondutoit:masterfrom
Open
Change some PL/pgsql functions to SQL#2davidfetter wants to merge 1 commit intoleondutoit:masterfrom
davidfetter wants to merge 1 commit intoleondutoit:masterfrom
Conversation
- In passing, use some more set-like reasoning
leondutoit
reviewed
Feb 9, 2019
| if untrusted_type = 'mac' then | ||
| select ntk.parse_mac_table_def(untrusted_definition) into _res; | ||
| return _res; | ||
| select ntk.parse_mac_table_def(untrusted_definition); |
Owner
There was a problem hiding this comment.
I get this error here, when running the tests: query has no destination for result data HINT: If you want to discard the results of a SELECT, use PERFORM instead..
| elsif untrusted_type = 'generic' then | ||
| select ntk.parse_generic_table_def(untrusted_definition) into _res; | ||
| return _res; | ||
| select ntk.parse_generic_table_def(untrusted_definition); |
| if untrusted_type = 'mac' then | ||
| select ntk.parse_mac_table_def(untrusted_definition) into _res; | ||
| return _res; | ||
| select ntk.parse_mac_table_def(untrusted_definition); |
Owner
There was a problem hiding this comment.
perhaps a good solution is return select ...
Owner
|
I think there might be some more issues when running the tests, would be great if you could confirm that all of them pass :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Too many functions are written in PL/pgsql #1