Add AMD ROCm GPU build and test CI infrastructure#1
Open
Conversation
ci/run.sh
Outdated
There was a problem hiding this comment.
This will affect the behavior of all builds even non ROCm ones. Please make a note about it.
There was a problem hiding this comment.
Looks like this will apply to CUDA/Vulkan/CPU as well
Is that intended?
Member
Author
There was a problem hiding this comment.
I am going to remove this, there is no real purpose.
Member
Author
There was a problem hiding this comment.
It was originally added to make this more compatible with windows.
* Introduce null-check to prevent SEGV * Fix error message
- Add self-hosted runner test jobs (test-rocm-linux, test-rocm-windows) for gfx1151/gfx1150 - Add cleanup composite actions for Linux and Windows runners - Add runner heartbeat monitoring workflow - Configure ci/run.sh with ROCm environment (HIP_PLATFORM, LD_LIBRARY_PATH, cmake flags) - Add Windows ROCm build support to build.yml - Fix conditional expression syntax warnings in build.yml
… should_build outputs to be specific. I ahve removed outputs.rocm_version from both ci steps, extracted resolve_rocm to a shared script for both jobs to use them. Fixed the matrix, removed both ubuntu-rocm and windows-rocm FGGML_ROCM=1 flag which doesn't apply because it isn't a real flag. Also commented out heartbeat runners.
…[^<]*\)<\/Key>.*/\1/gp'. This works on both Linux and Windows Git Bash.
…, sed and grep didn't work.
…p on windows doesnt work very well.
Geramy
force-pushed
the
geramy/rocm-build-tests-matrix
branch
from
6f435d0 to
cd3b5fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.