Open
Conversation
- Add vulkan backend version to backend_versions.json - Implement Vulkan backend download logic in sd_server.cpp - Support for Windows, Linux, and macOS platforms - Similar pattern to existing ROCm backend - Update test expectations to include vulkan in supported backends - Added vulkan to all relevant hardware profiles in server_system_info.py - Vulkan now available alongside cpu/rocm where appropriate
Contributor
Author
|
Forgot to add vulkan checks to CI workflow |
| {"amd_dgpu", {"gfx110X", "gfx120X"}}, | ||
| }}, | ||
|
|
||
| // stable-diffusion.cpp - Vulkan backend (cross-platform GPU) |
Member
There was a problem hiding this comment.
Should vulkan be the default over ROCm if its required for complex models to work?
Contributor
Author
There was a problem hiding this comment.
That makes sense.
Member
|
FYI: #1089 has a bunch of general fixes/improvements for SD support that will make this PR easier to test. |
Member
|
@ramkrishna2910 when testing this PR make sure to use Everything else will fail silently back to CPU, regardless of defaults. #1089 fixes that. |
Contributor
|
@makn87amd is there a minimum driver requirement? |
| }}, | ||
|
|
||
| // stable-diffusion.cpp - Vulkan backend (cross-platform GPU) | ||
| {"sd-cpp", "vulkan", {"windows"}, { |
Member
There was a problem hiding this comment.
Please add Linux Vulkan: sd-master-636d3cb-bin-Linux-Ubuntu-24.04-x86_64-vulkan.zip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Vulkan support to sd-cpp.
Vulkan seems to have more robust for SOTA models and may offer different performance compared with ROCm