confinement: add option to weigh by mass instead of volume #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManuelHu
force-pushed
the
sample-mass
branch
from
f1f7d14 to
e82931c
Compare
Contributor
|
I think for the background model we also want for some sources to give a different weighting, I am thinking of 2vbb where you want this proportional to mass*enrichment. |
Member
|
not sure how to implement? we would somehow need to extract the density of an isotope in the volume in the confinement code |
Contributor
|
Well enrichement fraction attached to the G4PhysicalVolume no? |
Member
|
There is no such thing attached to the G4 object |
Contributor
Author
|
surely we can calculate the mass fraction of an isotope, similar to what this PR already does to get the materials density. certainly not straightforward (the material api is horrible), but doable. |
Contributor
Author
|
I had a quick look, getting the mass of an isotope in a volume is ~ 10 lines of code. |
Contributor
Author
|
should now be all implemented and tested |
Contributor
|
Very nice!
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Manuel Huber ***@***.***>
Sent: Saturday, January 31, 2026 12:28:47 PM
To: legend-exp/remage ***@***.***>
Cc: Dixon, Toby ***@***.***>; Comment ***@***.***>
Subject: Re: [legend-exp/remage] confinement: add option to weigh by mass instead of volume (PR #519)
⚠ Caution: External sender
[https://avatars.githubusercontent.com/u/10050780?s=20&v=4]ManuelHu left a comment (legend-exp/remage#519)<#519 (comment)>
should now be all implemented and tested
—
Reply to this email directly, view it on GitHub<#519 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANSET44A3FASXABCEIKKKET4JSGW7AVCNFSM6AAAAACKNJ6DYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMRYGE4DSMZXGI>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.