-
Notifications
You must be signed in to change notification settings - Fork 2
Forced trigger #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Forced trigger #70
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 61.43% 58.35% -3.08%
==========================================
Files 19 19
Lines 1211 1280 +69
==========================================
+ Hits 744 747 +3
- Misses 467 533 +66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again you have some stuff that was already committed... i suspect you are doing something not correct with git
|
I can have a look at how much work is to do the correction on the times today. |
|
I do not think we should do it now, it isnt used for the main observables
…________________________________
From: Luigi Pertoldi ***@***.***>
Sent: Thursday, January 29, 2026 9:51 AM
To: legend-exp/legend-simflow ***@***.***>
Cc: Dixon, Toby ***@***.***>; Author ***@***.***>
Subject: Re: [legend-exp/legend-simflow] Forced trigger (PR #70)
⚠ Caution: External sender
[https://avatars.githubusercontent.com/u/20358192?s=20&v=4]gipert left a comment (legend-exp/legend-simflow#70)<#70 (comment)>
I can have a look at how much work is to do the correction on the times today.
—
Reply to this email directly, view it on GitHub<#70 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANSET46O7E3K4IMSWJLGJA34JHCYPAVCNFSM6AAAAACTHZP466VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMJWGMZDKMJRHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
i think we should for each simulated event look for a sample of random coincident pulse times in the data (in a certain window, e.g. 6 us) and just save this as an additional field in the opt tier. i think this would be useful to develop time/pattern based veto classifiers |
|
Definitely useful but not a main priority, and I think rather specialised just for that application.
We should start with just summed pe and multiplicity, our main observable defining the lar veto cut.
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Luigi Pertoldi ***@***.***>
Sent: Sunday, February 1, 2026 6:42:00 PM
To: legend-exp/legend-simflow ***@***.***>
Cc: Toby Dixon ***@***.***>; Author ***@***.***>
Subject: Re: [legend-exp/legend-simflow] Forced trigger (PR #70)
⚠ Caution: External sender
[https://avatars.githubusercontent.com/u/20358192?s=20&v=4]gipert left a comment (legend-exp/legend-simflow#70)<#70 (comment)>
i think we should for each simulated event look for a sample of random coincident pulse times in the data (in a certain window, e.g. 6 us) and just save this as an additional field in the opt tier. i think this would be useful to develop time/pattern based veto classifiers
—
Reply to this email directly, view it on GitHub<#70 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANSET44MFXNXL7RHG353QQ34JY3GRAVCNFSM6AAAAACTHZP466VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMZRGUZTSOBQG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This gives the basic function to create the forced trigger library in a format that https://reboost.readthedocs.io/en/stable/api/reboost.spms.html#reboost.spms.pe.corrected_photoelectrons can use.
For now we have not performed a forced trigger correction that returns the photon times, rather just the summed pe per channel. I think this is ok to start with.
If we want to instead obtain the nested vector of pe times we need new functionality in reboost.