Skip to content

Conversation

@tdixon97
Copy link
Collaborator

This gives the basic function to create the forced trigger library in a format that https://reboost.readthedocs.io/en/stable/api/reboost.spms.html#reboost.spms.pe.corrected_photoelectrons can use.

For now we have not performed a forced trigger correction that returns the photon times, rather just the summed pe per channel. I think this is ok to start with.

If we want to instead obtain the nested vector of pe times we need new functionality in reboost.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 8.10811% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.35%. Comparing base (2afea2c) to head (2a7b196).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
workflow/src/legendsimflow/reboost.py 8.10% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   61.43%   58.35%   -3.08%     
==========================================
  Files          19       19              
  Lines        1211     1280      +69     
==========================================
+ Hits          744      747       +3     
- Misses        467      533      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again you have some stuff that was already committed... i suspect you are doing something not correct with git

@gipert
Copy link
Member

gipert commented Jan 29, 2026

I can have a look at how much work is to do the correction on the times today.

@gipert gipert marked this pull request as draft January 29, 2026 08:51
@tdixon97
Copy link
Collaborator Author

tdixon97 commented Jan 29, 2026 via email

@gipert
Copy link
Member

gipert commented Feb 1, 2026

i think we should for each simulated event look for a sample of random coincident pulse times in the data (in a certain window, e.g. 6 us) and just save this as an additional field in the opt tier. i think this would be useful to develop time/pattern based veto classifiers

@tdixon97
Copy link
Collaborator Author

tdixon97 commented Feb 1, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants