Conversation
The kwargs psd_cal_pars_type/psd_cal_pars_cat were renamed to aoe_cal_pars_type/aoe_cal_pars_cat and aoe_cut_pars_type/aoe_cut_pars_cat in LegendEventAnalysis. Also include original error in LoadError message.
There was a problem hiding this comment.
Pull request overview
Updates processor code to align with an updated AoE-cut calibration API and improves error reporting, with an additional change to raw filekey filtering during hit-cal processing.
Changes:
- Update
p_process_aoe_cutto callcalibrate_ged_detector_datawith new AoE/AoE-cut kwarg names. - Improve AoE-cut load failure logging by including the truncated exception text.
- Change
process_hit_calraw input filekey filtering fromload_key=:unprocessabletoload_key=:all.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| processors/process_hit_cal.jl | Adjusts filtering criteria for raw calibration filekeys used during hit-cal processing. |
| processors/p_process_aoe_cut.jl | Updates AoE-cut calibration call kwargs and enhances error logging/exception messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -3,7 +3,7 @@ function process_hit_cal(processing_config::PropDict, l200::LegendData, period:: | |||
| @info "Generate cal hit for period $period and run $run" | |||
|
|
|||
There was a problem hiding this comment.
This change switches raw input filtering from load_key=:unprocessable to load_key=:all, which can materially change which raw files are used (e.g., for pulser tag extraction). If this is intentional, please add a brief rationale (or split into a separate PR) so the AoE-cut API update PR doesn’t also introduce an untracked processing-behavior change here.
| # NOTE: We intentionally use `load_key = :all` here so that both DSP and RAW file | |
| # lists include every available file, not only those marked as processable. | |
| # This is required to ensure pulser tag extraction sees the full set of RAW inputs | |
| # and does not silently drop files based on more restrictive filters (e.g. :unprocessable). |
| catch e | ||
| @error "E data for $det from cannot be loaded" | ||
| throw(LoadError("E data", 154, "E data for $det from partition $(part) cannot be loaded")) | ||
| @error "E data for $det from cannot be loaded: $(truncate_error(e))" |
There was a problem hiding this comment.
The log message has a grammatical/unclear fragment ("E data for $det from cannot be loaded"). Consider removing the stray "from" and/or including the same context as the thrown error (e.g., partition/run) so the log line is actionable on its own.
| @error "E data for $det from cannot be loaded: $(truncate_error(e))" | |
| @error "E data for $det from partition $(part) cannot be loaded: $(truncate_error(e))" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 5 5
Lines 518 518
=====================================
Misses 518 518 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.