Skip to content

perf: Nat.testBit builtin no-alloc implementation #12071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Kha wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

perf: Nat.testBit builtin no-alloc implementation #12071

Kha wants to merge 1 commit into from

Conversation

@Kha
Copy link
Member

@Kha Kha commented Jan 20, 2026

Would need more thorough review and second mpz implementation to get mergeable.

@Kha
Copy link
Member Author

Kha commented Jan 20, 2026

!bench

@leanprover-radar
Copy link

leanprover-radar commented Jan 20, 2026 •
edited
Loading

Benchmark results for 9bf6063 against 3dfd125 are in! @Kha

  • 🟥 build//instructions: +564.1M (+0.0%)

No significant changes detected.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 20, 2026
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Jan 20, 2026

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2026-01-14 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2026-01-20 13:22:19)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 20, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#12071
e2a35af
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Jan 20, 2026
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jan 20, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#12071
fcb1b3b
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jan 20, 2026
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 20, 2026

Mathlib CI status (docs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em will be requested when the pull request is marked ready for review kim-em is a code owner

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kha @leanprover-radar @leanprover-bot @leanprover-community-bot