Added add_headers() method to request objects#543
Open
DarkWiiPlayer wants to merge 3 commits intoleafo:masterfrom
DarkWiiPlayer:headers
Open
Added add_headers() method to request objects#543DarkWiiPlayer wants to merge 3 commits intoleafo:masterfrom DarkWiiPlayer:headers
add_headers() method to request objects#543DarkWiiPlayer wants to merge 3 commits intoleafo:masterfrom
DarkWiiPlayer:headers
Conversation
Contributor
Author
|
I have no idea why that was a |
DarkWiiPlayer
commented
May 21, 2017
lapis/request.moon
Outdated
| @buffer = {} -- output buffer | ||
| @params = {} | ||
| @options = {} | ||
| @add_headers: (headers) => |
Contributor
Author
There was a problem hiding this comment.
This mistake is probably a side-effect of writing too much CSS during the days leading up to this commit
Contributor
Author
|
@leafo I just remembered this pull request and noticed it's still open. Am I supposed to do something more, like a feature request ticked? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Because sometimes you may want to set headers progressively instead of just having one long header table at the end of your code. Specially useful when setting defaults in before-filters (UTF-8, spoofing the server, adding a lapis version header, etc.)
How?
By just adding a simple method that calls the add_header method of the response object (see code)
Example
I also couldn't resist removing a line of code that did absolutely nothing (again, see code)