Skip to content

Fix layout changes in Townhall infopage#11631

Open
Multiplication-golf wants to merge 2 commits intoldtteam:version/mainfrom
Multiplication-golf:version/main
Open

Fix layout changes in Townhall infopage#11631
Multiplication-golf wants to merge 2 commits intoldtteam:version/mainfrom
Multiplication-golf:version/main

Conversation

@Multiplication-golf
Copy link
Copy Markdown

@Multiplication-golf Multiplication-golf commented Apr 24, 2026

See #11622

-Enlarges the coordinates values box in the Townhall infopage

Review please

Dynamic box sizing might be a future update that could be considered as a addon of the BlockUI project

@github-actions
Copy link
Copy Markdown

In order for this pull request to be merged, make sure you test whether your changes work.

If the changes are working as intended, remove the https://github.com/ldtteam/minecolonies/labels/undefined label from the pull request.
As long as this label is on the pull request, it will not be merged.
If your pull request made no changes to the source code, the label will not be automatically added to the pull request.

Contributors, please review this pull request!

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 24, 2026

CLA assistant check
All committers have signed the CLA.

@Multiplication-golf
Copy link
Copy Markdown
Author

2026-04-24_14 13 40_2 Please remove the untested label

@Thodor12
Copy link
Copy Markdown
Contributor

Wouldn't it almost be better if we just showed a word saying "coordinates" and then just render the actual coordinates in a tooltip?

@uecasm
Copy link
Copy Markdown
Contributor

uecasm commented Apr 24, 2026

Wouldn't it almost be better if we just showed a word saying "coordinates" and then just render the actual coordinates in a tooltip?

If it was inline text, maybe, but here there's a dedicated row for the coords so it's better to just show them. It was just not wide enough before (which originally wouldn't have mattered, but somewhere around 1.18 text started wrapping & clipping rather than overflowing if the box was too small).

@Raycoms
Copy link
Copy Markdown
Contributor

Raycoms commented Apr 25, 2026

Wouldn't it almost be better if we just showed a word saying "coordinates" and then just render the actual coordinates in a tooltip?

If it was inline text, maybe, but here there's a dedicated row for the coords so it's better to just show them. It was just not wide enough before (which originally wouldn't have mattered, but somewhere around 1.18 text started wrapping & clipping rather than overflowing if the box was too small).

tbf I see this as a blockui bug that it doesn't overflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants