Skip to content

Resolve duplicate field entries in farm field module window.#11621

Open
armele wants to merge 3 commits intoldtteam:version/1.21from
armele:field_duplication
Open

Resolve duplicate field entries in farm field module window.#11621
armele wants to merge 3 commits intoldtteam:version/1.21from
armele:field_duplication

Conversation

@armele
Copy link
Copy Markdown
Contributor

@armele armele commented Apr 10, 2026

Closes discord observations: https://discord.com/channels/139070364159311872/1003402487417548801/1491852568102441141

Changes proposed in this pull request

  • Ensure that the BlockScarecrow bottom is used always for registration, even if the top is clicked.

Steps to reproduce (prior to code fix):

  • Start new colony.
  • Place farm with no field.
  • Place field.
  • Set seed from TOP half of scarecrow.
  • Observe that field is duplicated in the farm field module window (once with selected seed, once without).

Testing post-code fix is to follow the same process and observe only one entry.

Review please

@github-actions
Copy link
Copy Markdown

In order for this pull request to be merged, make sure you test whether your changes work.

If the changes are working as intended, remove the https://github.com/ldtteam/minecolonies/labels/undefined label from the pull request.
As long as this label is on the pull request, it will not be merged.
If your pull request made no changes to the source code, the label will not be automatically added to the pull request.

Contributors, please review this pull request!

@armele
Copy link
Copy Markdown
Contributor Author

armele commented Apr 10, 2026

Please remove the "untested" label. Testing was performed as described in the PR.

@Thodor12 Thodor12 removed the Untested label Apr 10, 2026
@armele
Copy link
Copy Markdown
Contributor Author

armele commented Apr 24, 2026

Please remove the "Untested" label. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants