-
Notifications
You must be signed in to change notification settings - Fork 54
chore: Create FDv2 polling and fallback data source #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Matthew M. Keeler <[email protected]>
keelerm84
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem okay to me, minus the bot feedback.
| @http_client = Impl::Util.new_http_client(config.base_uri, config) | ||
| .use(:auto_inflate) | ||
| .headers("Accept-Encoding" => "gzip") | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTTP client connections never closed, causing resource leak
Medium Severity
HTTPPollingRequester and HTTPFDv1PollingRequester create persistent HTTP connections via new_http_client (which calls .persistent()) but neither class provides a stop or close method to release these connections. The existing Requestor class follows the pattern of having a stop method that calls @http_client.close. Without cleanup methods, persistent connections holding file descriptors and sockets are never released when the data source is stopped, leading to resource leaks in long-running applications.
Note
Introduces FDv2 polling support and FDv1 fallback, wiring them into the data system and enhancing error/metadata handling.
PollingDataSourcewithfetch/sync, plus HTTP requestersHTTPPollingRequester(FDv2/sdk/poll) andHTTPFDv1PollingRequester(FDv1/sdk/latest-all) with ETag/304 handling and header extraction (x-launchdarkly-env-id,x-launchdarkly-fd-fallback).PollingDataSourceBuilderandFDv1PollingDataSourceBuilderand exposes them viaDataSystem.polling_ds_builderandfdv1_fallback_ds_builder.polling_payload_to_changeset(FDv2 events) andfdv1_polling_payload_to_changeset(flags/segments) returningChangeSets.Resultto include optionalheaders; fixesChangeSetBuilder.no_changesto useSelector.no_selector.Written by Cursor Bugbot for commit 85bc160. This will update automatically on new commits. Configure here.