feat: adds fdv2 payload parsing and protocol handling #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
reviewed
Jan 13, 2026
| */ | ||
| public abstract class GsonHelpers { | ||
| private static final Gson GSON_INSTANCE = new Gson(); | ||
| private static final Gson GSON_INSTANCE = new GsonBuilder() |
Member
There was a problem hiding this comment.
For other types I think this was handled by a type adapter factory?
Contributor
Author
There was a problem hiding this comment.
I'm a dummy, I clicked merge before I saw this. Let me take a look.
kinyoklion
approved these changes
Jan 13, 2026
kinyoklion
requested changes
Jan 13, 2026
Member
kinyoklion
left a comment
kinyoklion
left a comment
There was a problem hiding this comment.
I am un-approving because I think we cannot do these as chores. Because we need to release the library.
tanderson-ld
changed the title
kinyoklion
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Unable to with just this part of code.
Related issues
SDK-1607
Describe the solution you've provided
Porting of Dotnet Server SDK Implementation
BEGIN_COMMIT_OVERRIDE
feat: adds fdv2 payload parsing and protocol handling
END_COMMIT_OVERRIDE