Open
Conversation
This reverts commit 7148510.
does not block adding/refreshing new minions if one minion doesnt respond
Closed
|
+1 to this PR, I've been trying alcali lately but been unable to get even one minion on the list. I see alcali gathering the data on the minions but nothing appears ever on the page, so I guess it's because of the problems mentioned here. I have some hundreds minions on my salt master, increased all the timeouts that were failing initially but still nothing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we found several issues that made alcali unusable on a large salt instance.
the minions list or conformity would not load at all.
there was an assumption that it would also have a dict but some of the responses were strings (unhandled failures on the state.apply on minion side)
we have a postgres db with over 20gb of history that pointed out some of the load issues.
the "users" logic on search is the most broken piece, it does not scale and we removed it as it was unworkable. an indexing task to index jobs to pull out userid into its own column would help a lot