Rename log-parser to query and improve usability #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daiki Ueno <[email protected]>
It is a common use-case to monitor cryptographic usage on the system at real time. This adds a dedicated CLI tool, crau-monitor, by combining the functionalities of event-broker and client. Unlike those, crau-monitor doesn't require any system service but directly reads the log file. Signed-off-by: Daiki Ueno <[email protected]>
Signed-off-by: Daiki Ueno <[email protected]>
Signed-off-by: Daiki Ueno <[email protected]>
Signed-off-by: Daiki Ueno <[email protected]>
Signed-off-by: Daiki Ueno <[email protected]>
t184256
reviewed
Jan 20, 2026
| let log_file = std::fs::File::open(&cli.log_path) | ||
| .with_context(|| format!("unable to read file `{}`", cli.log_path.display()))?; | ||
| let config = config::Config::new()?; | ||
| Pager::new().setup(); |
Collaborator
There was a problem hiding this comment.
Should we use Pager::new().skip_on_notty().setup()? I'm surprised is not the default.
| let inotify_stream = inotify.into_event_stream(buffer)?; | ||
| let watch_descriptor = inotify_stream | ||
| .watches() | ||
| .add(&log_file, WatchMask::MODIFY | WatchMask::CREATE) |
Collaborator
There was a problem hiding this comment.
same CREATE concern as in #206. hope there's some crate where it's already implemented, cause it feels quite involved. separate issue for the future?
Collaborator
There was a problem hiding this comment.
https://github.com/aravindavk/logwatcher/blob/master/src/lib.rs, except with a notify on the parent instead of sleeping?
| if !self.all_contexts.contains_key(group.context()) { | ||
| // Either this library did not do a new_context for this context, or the | ||
| // log we have is truncated at the beginning. Just assume that this context | ||
| // has no parent and create a new one so we don't loose the information in |
| ) | ||
| .required(false) | ||
| .value_parser(value_parser!(PathBuf)) | ||
| .default_value("audit.cborseq"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames crau-log-parser to crau-query, and attempts to add the following usability improvements:
--sinceand--untiloption to filter events by date (TODO)Fixes: #154