Ability to pass meta data along with push notifications#65
Ability to pass meta data along with push notifications#65Stalinko wants to merge 2 commits intolaravel-notification-channels:masterfrom
Conversation
|
|
|
@Stalinko I see that a ton of time has passed but any idea if this PR will ever be merged or we are supposed to patch the library with the diff ourselves? |
|
@hypnocill for some reason the maintainer of this project doesn't react at my PRs, seems like he abandoned it. @themsaid @freekmurze @atymic what's the state of this project? Would you have some time to accept the PRs? |
|
@Stalinko I see, thanks for answering. How did you proceed, did you patch the library yourself, forked it or found another one? |
|
@hypnocill you can use my fork (https://github.com/Stalinko/pusher-push-notifications/tree/meta-data) directly in composer until this PR is accepted. In composer.json inside and also add this block to the end of the file: |
|
@Stalinko |
- Update Pusher Beams message to pass meta data along with message parameters: @see https://pusher.com/docs/beams/guides/publishing-to-multiple-devices#adding-metadata-to-a-notification - From PR laravel-notification-channels#65 laravel-notification-channels#65
This PR replicates this one but without it's issues: #49
I'll just copy the description:
Pusher Beams allows passing meta data along with message parameters: https://pusher.com/docs/beams/guides/publishing-to-multiple-devices#adding-metadata-to-a-notification
I'm using that in my project and decided to format as a handy API in
PusherMessageclass.Tests added.
Also added
.ideafolder into.gitignore. It's created by PHPStorm.