-
Notifications
You must be signed in to change notification settings - Fork 19.9k
refactor(typing): Fixup typing A2 - workflow engine & nodes #31723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BeautyyuYanli
wants to merge
20
commits into
langgenius:main
Choose a base branch
from
BeautyyuYanli:yanli/remove-ty-a2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+219
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
75a040f to
f00402c
Compare
b160322 to
8a25a2a
Compare
Contributor
Contributor
Author
Thx. Any is enough in this case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🌊 feat:workflow
Workflow related stuff.
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of #31680 (A2 stage: workflow engine & nodes).
What this PR does
Unblocks running
tyon the workflow engine/nodes layer by tightening types, improving narrowing, and removing a few cross-layer import/typing issues.Key changes:
Typed workflow node config
core.workflow.entities.graph_configwithNodeConfigDict+NodeConfigDictAdapter.core.workflow.graph.graph.Graph) to validate node configs via PydanticTypeAdapterand use typed indexing.Workflow.get_node_config_by_id()and workflow entry code to use the typed node config.Protocol-friendly dependency injection for HTTP request node
core.helper.ssrf_proxy.SSRFProxyimplementingHttpClientProtocolcore.file.file_manager.FileManagerimplementingFileManagerProtocolHttpRequestNode/ executor andDifyNodeFactoryto accept optional injected deps with safe defaults (no behavioral change intended).Type/narrowing cleanups inside workflow code
cast()usage where types are already structurally guaranteed.isinstance) and a few small typing fixes in nodes (e.g. LLM prompt content handling, list operator file field extraction, datasource type conversion).Tooling
tyto>=0.0.14and updatesty.tomlrules/excludes for this stage.Why
The workflow codebase has import-linter enforced layering, including that
core.workflow.nodes.*must not importcore.workflow.graph.*.During the A2 work,
models/workflow.pyimporting node-config typing fromcore.workflow.graph.graphcreated an indirect dependency chain that broke the rule once graph parsing started depending on node-typed configs.Moving the shared node-config
TypedDictintocore.workflow.entitieskeeps the architecture boundary intact while still allowingGraph/Workflow/factories to share the same validated config shape.Testing
uv run --directory api --dev ty checkuv run --directory api --dev lint-imports