fix: use query params instead of request body for decode_plugin_from_identifier

[minodisk]

Summary

• Changed decode_plugin_from_identifier to use query parameters (params=) instead of request body (data=)
• Removed unnecessary Content-Type: application/json header

Problem

The decode_plugin_from_identifier endpoint was sending plugin_unique_identifier in the request body with a GET request. This causes issues with HTTP intermediaries like Google Cloud Run's frontend, which rejects GET requests with a body as malformed (returning 400 Bad Request before the request reaches the container).

Solution

Changed from data= (request body) to params= (query parameters), which is:

• Consistent with similar GET endpoints (fetch_plugin_manifest, fetch_plugin_by_identifier)
• Compliant with HTTP standards
• Compatible with Cloud Run and other HTTP proxies/load balancers

Related PR

This change requires a corresponding change in dify-plugin-daemon to accept the parameter from query string instead of JSON body:

• fix: accept plugin_unique_identifier from query params for DecodePluginFromIdentifier dify-plugin-daemon#593

[gemini-code-assist]

Summary of Changes

Hello @minodisk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where GET requests to the decode_plugin_from_identifier endpoint were failing due to the inclusion of a request body, which is non-standard for GET operations and rejected by various HTTP proxies. The solution involves refactoring the request to pass the identifier as a query parameter, aligning it with HTTP best practices and ensuring robust functionality across different deployment environments.

Highlights

• API Endpoint Modification: The decode_plugin_from_identifier endpoint has been updated to utilize query parameters (params=) instead of a request body (data=) for passing the plugin_unique_identifier.
• Header Removal: The unnecessary Content-Type: application/json header has been removed from the decode_plugin_from_identifier GET request.
• HTTP Compliance & Compatibility: These changes resolve issues with HTTP intermediaries, such as Google Cloud Run, which previously rejected GET requests containing a body, ensuring compliance with HTTP standards and broader compatibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly resolves an issue where a GET request was being sent with a request body, which is not compliant with HTTP standards and can be rejected by intermediaries like proxies and load balancers. The modification to use query parameters (params) instead of a request body (data) for the decode_plugin_from_identifier endpoint is the proper fix. This change also improves consistency with other GET endpoints in the file, such as fetch_plugin_manifest and fetch_plugin_by_identifier. The change is well-contained and the reasoning is clearly explained in the pull request description. Excellent work on this fix.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.