refactor(FR-1929): remove all model_card_metadata.json related code#6226
Draft
refactor(FR-1929): remove all model_card_metadata.json related code#6226
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.14% (+0.02% 🔼) |
1403/17231 |
| 🔴 | Branches | 7.34% (+0.03% 🔼) |
883/12033 |
| 🔴 | Functions | 5.35% (+0.01% 🔼) |
258/4821 |
| 🔴 | Lines | 7.84% (+0.02% 🔼) |
1316/16785 |
Test suite run success
773 tests passing in 36 suites.
Report generated by 🧪jest coverage report action from dde4314
Remove the useModelCardMetadata hook, model_card_metadata.json, model_card_metadata.schema.json, and all references in ModelStoreListPage and ModelCardModal. Also delete orphaned ModelCardChat.tsx component whose only import was removed. The team decided not to use model_card_metadata.json anymore.
yomybaby
force-pushed
the
03-27-refactor_fr-1929_remove_all_model_card_metadata_json_related_code
branch
from
37ad3a0 to
dde4314
Compare
github-actions
bot
added
quick-capture
size:L
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated model_card_metadata.json mechanism from Backend.AI WebUI, eliminating the associated hook/resources and simplifying Model Store UI behavior that depended on that metadata.
Changes:
- Deleted
useModelCardMetadatahook and themodel_card_metadata.json+ schema resources. - Removed metadata-dependent sorting and thumbnail lookup from
ModelStoreListPage. - Removed metadata-dependent chat rendering from
ModelCardModaland cleaned up.gitignore.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| react/src/hooks/useModelCardMetadata.tsx (deleted) | Removes the client-side fetch/caching hook for model card metadata JSON. |
| resources/model_card_metadata.json (deleted) | Removes unused metadata JSON artifact. |
| resources/model_card_metadata.schema.json (deleted) | Removes unused JSON schema for the metadata file. |
| react/src/pages/ModelStoreListPage.tsx | Removes sorting/thumbnail lookup based on deleted metadata; uses default thumbnail. |
| react/src/components/ModelCardModal.tsx | Removes metadata list lookup and the metadata-gated chat UI block. |
| react/src/components/ModelCardChat.tsx (deleted) | Removes now-unreferenced chat component previously gated by metadata presence. |
| .gitignore | Removes ignore rule for the deleted metadata JSON file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5068(FR-1929)
Summary
useModelCardMetadatahook,model_card_metadata.json, andmodel_card_metadata.schema.jsonModelStoreListPage(sorting logic, thumbnail lookup) andModelCardModal(metadata list check, ModelCardChat conditional render).gitignoreentry formodel_card_metadata.jsonFiles changed
react/src/hooks/useModelCardMetadata.tsxresources/model_card_metadata.jsonresources/model_card_metadata.schema.jsonreact/src/pages/ModelStoreListPage.tsx— removed import,models/sortingusage, sorting logic, and thumbnail lookup from metadatareact/src/components/ModelCardModal.tsx— removed import,modelMetadataListreferences,ModelCardChatconditional block, and unusedModelCardChatimport.gitignore— removedresources/model_card_metadata.jsonentryTest plan
🤖 Generated with Claude Code