feat(FR-2326): highlight failure steps with error color in scheduling history#6225
Draft
feat(FR-2326): highlight failure steps with error color in scheduling history#6225
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 84.55% | 427/505 |
| 🟡 | Branches | 70.98% | 362/510 |
| 🟡 | Functions | 79.49% | 93/117 |
| 🟢 | Lines | 86.28% | 390/452 |
Test suite run success
319 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from 8d3b0f5
yomybaby
force-pushed
the
03-27-feat_fr-2326_highlight_failure_steps_with_error_color
branch
from
f42f204 to
b4b3cd8
Compare
github-actions
bot
added
apc-sync
q-cap
quick-capture
size:S
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the scheduling history modal UX by highlighting failed sub-steps using Ant Design’s theme-aware error color, making failures easier to spot in both light and dark modes.
Changes:
- Introduces a
FAILURE_RESULTSlist for failure-like scheduling outcomes. - Applies
token.colorErrorstyling to the sub-step name and result display when the sub-step result indicates failure. - Uses
theme.useToken()so the highlight color follows the active Ant Design theme.
packages/backend.ai-ui/src/components/fragments/BAISessionHistorySubStepNodes.tsx
Show resolved
Hide resolved
packages/backend.ai-ui/src/components/fragments/BAISessionHistorySubStepNodes.tsx
Show resolved
Hide resolved
yomybaby
force-pushed
the
03-27-feat_fr-2326_highlight_failure_steps_with_error_color
branch
from
b4b3cd8 to
8d3b0f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6047(FR-2326)
Summary
token.colorError(antd theme token) to the step name and result text columns when the scheduling result isFAILURE,EXPIRED, orGIVE_UPtheme.useToken()so the error color automatically adapts to both dark and light modeBAISessionHistorySubStepNodes.tsxTest plan