Skip to content

fix(FR-2384): enable LLM Chat Test button when any route is HEALTHY#6178

Open
nowgnuesLee wants to merge 1 commit intomainfrom
03-26-fix_fr-2384_enable_llm_chat_test_button_when_any_route_is_healthy
Open

fix(FR-2384): enable LLM Chat Test button when any route is HEALTHY#6178
nowgnuesLee wants to merge 1 commit intomainfrom
03-26-fix_fr-2384_enable_llm_chat_test_button_when_any_route_is_healthy

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee commented Mar 26, 2026

Resolves #6176 (FR-2384)

Summary

  • The "LLM Chat Test" button was previously disabled unless the endpoint's overall status was HEALTHY
  • Changed to check if any individual route has HEALTHY status by adding a separate healthyRoutes query with filter: { status: [HEALTHY] }
  • This allows users to test LLM chat as long as at least one route is healthy, even if the endpoint itself isn't fully healthy
  • Falls back to endpoint status check for servers that don't support route-node

Changes

  • react/src/pages/EndpointDetailPage.tsx
    • Added healthyRoutes alias query to fetch count of HEALTHY routes
    • Added hasAnyHealthyRoute derived state
    • Changed button disabled condition from endpoint?.status !== 'HEALTHY' to !hasAnyHealthyRoute

Test plan

  • Deploy an endpoint with multiple routes where some are HEALTHY and some are not
  • Verify the "LLM Chat Test" button is enabled when at least one route is HEALTHY
  • Verify the button is disabled when no routes are HEALTHY
  • Verify behavior on older backends without route-node support (should fall back to endpoint status)

🤖 Generated with Claude Code

Copy link
Copy Markdown
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
8.12% (-0% 🔻)
1403/17286
🔴 Branches
7.31% (+0% 🔼)
883/12073
🔴 Functions 5.34% 258/4834
🔴 Lines
7.81% (-0% 🔻)
1316/16840

Test suite run success

773 tests passing in 36 suites.

Report generated by 🧪jest coverage report action from b1d3e63

@nowgnuesLee nowgnuesLee force-pushed the 03-26-fix_fr-2384_enable_llm_chat_test_button_when_any_route_is_healthy branch from e58c011 to 780a6b8 Compare March 26, 2026 06:21
@github-actions github-actions bot added size:L 100~500 LoC and removed size:XS ~10 LoC labels Mar 26, 2026
@nowgnuesLee nowgnuesLee force-pushed the 03-26-fix_fr-2384_enable_llm_chat_test_button_when_any_route_is_healthy branch from 780a6b8 to 1548b84 Compare March 26, 2026 06:31
@nowgnuesLee nowgnuesLee marked this pull request as ready for review March 26, 2026 10:34
@nowgnuesLee nowgnuesLee requested review from agatha197, Copilot, ironAiken2 and yomybaby and removed request for Copilot March 26, 2026 10:35
Copilot AI review requested due to automatic review settings March 27, 2026 07:10
@nowgnuesLee nowgnuesLee force-pushed the 03-26-fix_fr-2384_enable_llm_chat_test_button_when_any_route_is_healthy branch from 1548b84 to 9b328a9 Compare March 27, 2026 07:10
@nowgnuesLee nowgnuesLee requested a review from ironAiken2 March 27, 2026 07:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Endpoint Detail page so the “LLM Chat Test” button is enabled when at least one underlying route is HEALTHY (instead of requiring the overall endpoint status to be HEALTHY), with a fallback path for backends that don’t support route-node.

Changes:

  • Adds a healthyRoutes alias query (filtered to HEALTHY) and derives hasAnyHealthyRoute to drive the button’s disabled state.
  • Switches the “LLM Chat Test” button disabling logic to !hasAnyHealthyRoute.
  • Removes desired_session_count fallbacks in a couple places (replica display + destroying-category helper), which affects backward compatibility.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
react/src/pages/EndpointDetailPage.tsx Adds a healthyRoutes count query and uses it to decide whether to enable “LLM Chat Test”; also changes replica display to use replicas only.
react/src/components/EndpointList.tsx Adjusts isEndpointInDestroyingCategory to consider replicas only (dropping desired_session_count).

Copy link
Copy Markdown
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that some of the comments I left have not been addressed. Please check this.

@nowgnuesLee nowgnuesLee force-pushed the 03-26-fix_fr-2384_enable_llm_chat_test_button_when_any_route_is_healthy branch from 9b328a9 to 19ae0a7 Compare March 27, 2026 08:12
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Mar 27, 2026
Add an aliased healthyRoutes query with filter { status: [HEALTHY] }
to check if any route is healthy, and use its count to determine
whether the LLM Chat Test button should be enabled.

Resolves #6177(FR-2384)
@nowgnuesLee nowgnuesLee force-pushed the 03-26-fix_fr-2384_enable_llm_chat_test_button_when_any_route_is_healthy branch from 19ae0a7 to b1d3e63 Compare March 27, 2026 08:18
@nowgnuesLee nowgnuesLee requested a review from ironAiken2 March 27, 2026 08:19
Copy link
Copy Markdown
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable LLM Chat Test button when any route status is HEALTHY

3 participants