Skip to content

Conversation

@nowgnuesLee
Copy link
Contributor

@nowgnuesLee nowgnuesLee commented Jan 20, 2026

resolves #4931 (FR-1859)

This PR improves the Relay Infinite Scroll Select skill documentation and implementation by:

  1. Introducing a clearer decision tree based on dynamic query parameter needs
  2. Adding a new Pattern B (Dynamic) that provides full control over query parameters
  3. Implementing BAIUserSelect component as a reference for email-based selection with dynamic parameters
  4. Adding dynamic first parameter to ensure all selected values are fetched efficiently
  5. Updating BAIVFolderSelect to use dynamic first parameter for better data completeness
  6. Providing detailed comparison between Simple and Dynamic patterns
  7. Adding comprehensive examples and best practices for both patterns

The key innovation is the dynamic first parameter that calculates exactly how many items to fetch based on selection count, preventing both over-fetching and under-fetching of data.

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author

nowgnuesLee commented Jan 20, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

Coverage report for ./packages/backend.ai-ui

St.
Category Percentage Covered / Total
🟡 Statements 63.21% 256/405
🔴 Branches 41.94% 151/360
🔴 Functions 49.46% 46/93
🟡 Lines 64.71% 231/357

Test suite run success

186 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 203865c

@nowgnuesLee nowgnuesLee force-pushed the feat/create-BAIUserSelect branch from cb6bab3 to 7c927a8 Compare January 26, 2026 08:42
@nowgnuesLee nowgnuesLee force-pushed the feat/create-agent-skills-for-infinity-scroll-select-components branch from 2d08ba9 to 38d47d4 Compare January 26, 2026 08:42
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Jan 26, 2026
@github-actions
Copy link
Contributor

Missing Storybook Stories

The following 2 component(s) are missing Story files:

  • packages/backend.ai-ui/src/components/fragments/BAIUserSelect.tsx -> missing packages/backend.ai-ui/src/components/fragments/BAIUserSelect.stories.tsx
  • packages/backend.ai-ui/src/components/fragments/BAIVFolderSelect.tsx -> missing packages/backend.ai-ui/src/components/fragments/BAIVFolderSelect.stories.tsx

Storybook guidelines

@nowgnuesLee nowgnuesLee force-pushed the feat/create-BAIUserSelect branch from 7c927a8 to 6da290a Compare January 26, 2026 09:17
@nowgnuesLee nowgnuesLee marked this pull request as ready for review January 26, 2026 09:32
Copilot AI review requested due to automatic review settings January 26, 2026 09:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new BAIUserSelect component implementing Pattern B (Dynamic) for infinite scroll with full control over query parameters, and enhances the Relay infinite scroll select documentation to better guide developers in choosing between patterns.

Changes:

  • Adds BAIUserSelect component with email-based selection, dynamic first parameter, and infinite scroll support
  • Updates BAIVFolderSelect to use dynamic first parameter for consistency
  • Adds comprehensive i18n translations for SelectUser across all supported languages
  • Significantly improves documentation with clearer decision trees, pattern comparisons, and detailed implementation guides

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/backend.ai-ui/src/components/fragments/BAIUserSelect.tsx New component implementing Pattern B with dynamic query parameters, email-based filtering, and infinite scroll
packages/backend.ai-ui/src/components/fragments/BAIVFolderSelect.tsx Added dynamic first parameter to ensure all selected values are fetched
packages/backend.ai-ui/src/components/fragments/index.ts Exported BAIUserSelect component and related types
packages/backend.ai-ui/src/locale/*.json (20 files) Added comp:BAIUserSelect.SelectUser translations for all supported languages
.claude/skills/relay-infinite-scroll-select/SKILL.md Enhanced with clearer decision tree, dynamic first parameter documentation, and Pattern B clarification
.claude/skills/relay-infinite-scroll-select/references/patterns/BAIUserSelect.md New comprehensive documentation for BAIUserSelect pattern with examples and best practices
.claude/skills/relay-infinite-scroll-select/references/patterns/BAIVFolderSelect.md Updated to document dynamic first parameter usage

Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears network request optimization is needed, such as applying debounce during input for search. There also seems to be no need to use two queries internally.

@nowgnuesLee nowgnuesLee force-pushed the feat/create-BAIUserSelect branch from 6da290a to 6c8ff72 Compare January 28, 2026 04:16
@nowgnuesLee nowgnuesLee force-pushed the feat/create-agent-skills-for-infinity-scroll-select-components branch from 38d47d4 to f6d1081 Compare January 28, 2026 04:16
@nowgnuesLee nowgnuesLee force-pushed the feat/create-BAIUserSelect branch from 6c8ff72 to 149dd18 Compare January 28, 2026 04:25
@nowgnuesLee nowgnuesLee force-pushed the feat/create-BAIUserSelect branch 2 times, most recently from 558202c to eeb7492 Compare January 29, 2026 02:25
@nowgnuesLee nowgnuesLee force-pushed the feat/create-agent-skills-for-infinity-scroll-select-components branch from f6d1081 to 5895891 Compare January 30, 2026 07:59
@nowgnuesLee nowgnuesLee force-pushed the feat/create-BAIUserSelect branch from eeb7492 to 203865c Compare January 30, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants