-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1859): Create a BAIUserSelect #5055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/create-agent-skills-for-infinity-scroll-select-components
Are you sure you want to change the base?
feat(FR-1859): Create a BAIUserSelect #5055
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 63.21% | 256/405 |
| 🔴 | Branches | 41.94% | 151/360 |
| 🔴 | Functions | 49.46% | 46/93 |
| 🟡 | Lines | 64.71% | 231/357 |
Test suite run success
186 tests passing in 9 suites.
Report generated by 🧪jest coverage report action from 203865c
cb6bab3 to
7c927a8
Compare
2d08ba9 to
38d47d4
Compare
Missing Storybook StoriesThe following 2 component(s) are missing Story files:
|
7c927a8 to
6da290a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a new BAIUserSelect component implementing Pattern B (Dynamic) for infinite scroll with full control over query parameters, and enhances the Relay infinite scroll select documentation to better guide developers in choosing between patterns.
Changes:
- Adds
BAIUserSelectcomponent with email-based selection, dynamicfirstparameter, and infinite scroll support - Updates
BAIVFolderSelectto use dynamicfirstparameter for consistency - Adds comprehensive i18n translations for
SelectUseracross all supported languages - Significantly improves documentation with clearer decision trees, pattern comparisons, and detailed implementation guides
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/backend.ai-ui/src/components/fragments/BAIUserSelect.tsx |
New component implementing Pattern B with dynamic query parameters, email-based filtering, and infinite scroll |
packages/backend.ai-ui/src/components/fragments/BAIVFolderSelect.tsx |
Added dynamic first parameter to ensure all selected values are fetched |
packages/backend.ai-ui/src/components/fragments/index.ts |
Exported BAIUserSelect component and related types |
packages/backend.ai-ui/src/locale/*.json (20 files) |
Added comp:BAIUserSelect.SelectUser translations for all supported languages |
.claude/skills/relay-infinite-scroll-select/SKILL.md |
Enhanced with clearer decision tree, dynamic first parameter documentation, and Pattern B clarification |
.claude/skills/relay-infinite-scroll-select/references/patterns/BAIUserSelect.md |
New comprehensive documentation for BAIUserSelect pattern with examples and best practices |
.claude/skills/relay-infinite-scroll-select/references/patterns/BAIVFolderSelect.md |
Updated to document dynamic first parameter usage |
ironAiken2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears network request optimization is needed, such as applying debounce during input for search. There also seems to be no need to use two queries internally.
6da290a to
6c8ff72
Compare
38d47d4 to
f6d1081
Compare
6c8ff72 to
149dd18
Compare
558202c to
eeb7492
Compare
f6d1081 to
5895891
Compare
eeb7492 to
203865c
Compare

resolves #4931 (FR-1859)
This PR improves the Relay Infinite Scroll Select skill documentation and implementation by:
BAIUserSelectcomponent as a reference for email-based selection with dynamic parametersfirstparameter to ensure all selected values are fetched efficientlyBAIVFolderSelectto use dynamicfirstparameter for better data completenessThe key innovation is the dynamic
firstparameter that calculates exactly how many items to fetch based on selection count, preventing both over-fetching and under-fetching of data.Checklist: