add region, machine-type and worker-pool flags to image builder#36296
Open
upodroid wants to merge 1 commit intokubernetes:masterfrom
Open
add region, machine-type and worker-pool flags to image builder#36296upodroid wants to merge 1 commit intokubernetes:masterfrom
upodroid wants to merge 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for kubernetes/kubernetes#136464
We have some builds that need to use a worker pool so we need to set them as extra flags. machine type and worker-pool can't be set at the same time.
Also, the image builder will warn you if you are using GCB to push a single arch image. We shouldn't be doing that anymore, as described here. https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md