-
Notifications
You must be signed in to change notification settings - Fork 437
Enhancements handbook updates #2932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - [ ] KEP status is marked as `implementable` for `latest-milestone: { CURRENT_RELEASE }`. | ||
| - [ ] KEP readme has up-to-date graduation criteria. | ||
| - [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check [here](https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md#submitting-a-kep-for-production-readiness-approval)). | ||
| - [ ] There are no other outstanding (unmerged) PRs that modify the KEP readme or kep.yaml file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this checkbox is new
| - [X] KEP readme has up-to-date graduation criteria. | ||
| - [X] KEP has [submitted a production readiness review](https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md#submitting-a-kep-for-production-readiness-approval) request for approval and has a reviewer assigned. | ||
| - [X] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check [here](https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md#submitting-a-kep-for-production-readiness-approval)). | ||
| - [X] There are no other outstanding (unmerged) PRs that modify the KEP readme or kep.yaml file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this checkbox is new
|
|
||
| If you still wish to progress this enhancement in {current release}, please file an [exception](https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md) request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks! | ||
|
|
||
| /remove-label tracked/yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this to clear out the existing tracked label
|
|
||
| If you still wish to progress this enhancement in {current release}, please file an [exception](https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md) request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks! | ||
|
|
||
| /remove-label tracked/yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this to clear out the existing tracked label
| - List of members for this group is managed in git. Create a [pull request](https://github.com/kubernetes/k8s.io/pull/1533) against [kubernetes/k8s.io](https://github.com/kubernetes/k8s.io/) repo to include both Lead and Shadows under `release-team` group in [k8s.io/sig-release/group.yaml](https://github.com/kubernetes/k8s.io/blob/bd082f195599b8a86b76b0249e5f70f219f1d079/groups/sig-release/groups.yaml#L318) | ||
| - MUST be a member of the [SIG Release Google Group][sig-release-group] | ||
| - MUST be a member of the [SIG Architecture Google Group][sig-arch-group] | ||
| - MUST be a member of the [Kubernetes Enhancements Google Group][enhancements-group] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as i can tell, this group is not used so i removed it from the requirements
| #### Why check for untracked user-facing features | ||
| | Status | Description | | ||
| |-----------------------:|---------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | Tracked For PRR Freeze | Enhancement has met all PRR Freeze requirements for inclusion into current release. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the PRR Freeze statuses and updated some of the text below
|
|
||
| # Code Freeze Exceptions requested in v1.35 | ||
| During the meeting: | ||
| - Unhold (`/unhold`) the PR enforcing code freeze, allowing it to merge. This will prevent any PRs from merging unless they are in the current milestone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these Code Freeze Party steps were added
| - Cleanup old milestones | ||
| - Open a pull request to add the exceptions.yaml file with all the KEPs which applied for an exception during enhancements freeze and code freeze. You can find an example of this exceptions.yaml file [here](https://github.com/kubernetes/sig-release/blob/master/releases/release-1.29/exceptions.yaml). | ||
|
|
||
| ### Limitations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to the Process section above
|
|
||
| It is important that this process be followed and documentation remain up-to-date as the [Enhancements repo][k/enhancements] is the primary ingress point for contributors interested in tracking enhancements. | ||
|
|
||
| ### Milestone Activities + Timing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved this section to below the Process section
|
|
||
| If the Enhancement Issue **does** meet the enhancement freeze criteria for inclusion in the current release (and has not already been marked as `Tracked for enhancements freeze`), use this template in Issue comments: | ||
| ### Week of Enhancements Freeze | ||
| - Schedule an "Enhancements Freeze Party" for the day of the Enhancements Freeze. Invite all the Enhancement shadows, Emeritus Advisor, Release Team Lead and Lead Shadows (make participation optional for the invitees due to potential timezone differences.) Post the "Enhancements Freeze Party" meeting details in the #sig-release and #release-enhancements Kubernetes Slack channels. **Note**: It is helpful to delegate enhancements to review to shadows to help with the process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Schedule an "Enhancements Freeze Party" for the day of the Enhancements Freeze. Invite all the Enhancement shadows, Emeritus Advisor, Release Team Lead and Lead Shadows (make participation optional for the invitees due to potential timezone differences.) Post the "Enhancements Freeze Party" meeting details in the #sig-release and #release-enhancements Kubernetes Slack channels. **Note**: It is helpful to delegate enhancements to review to shadows to help with the process. | |
| - Schedule an "Enhancements Freeze Party" for the day of the Enhancements Freeze. Invite all the Enhancement shadows, Subproject Leads, Release Team Lead and Lead Shadows (make participation optional for the invitees due to potential timezone differences.) Post the "Enhancements Freeze Party" meeting details in the #sig-release and #release-enhancements Kubernetes Slack channels. **Note**: It is helpful to delegate enhancements to review to shadows to help with the process. |
|
/lgtm I suggested a small change. As you said there are definitely other areas that need to be updated, especially now that PRR Freeze is a hard deadline (e.g. Enhancements board sync should be disabled at the PRR freeze deadline instead of enhancements freeze), but these can be raised in a separate PR. |
|
/approve Not sure if I'd have the approval right, just trying with hold as well |
|
I'll let this merge and open a follow-up PR with further changes (including addressing any PR comments from this one) /unhold |
420ebd2 to
94e2e23
Compare
|
New changes are detected. LGTM label has been removed. |
94e2e23 to
44235ba
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jenshu, rytswd The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
sorry, messed up the rebase. Use #2952 instead |
What type of PR is this:
/kind documentation
What this PR does / why we need it:
The Release Enhancements handbook was getting a bit unwieldy with lots of info, so moved some things around to make it easier to navigate:
Processsection to make theMilestone Activities + Timingmore easy to follow.Also some fixes and retros items:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
There is further cleanup that can be done, but didn't want to have too many moving parts at once.
I added PR comments to sections that have changed, to make it easier to review.
Since a lot of sections were just moved around, it's hard to review the diff and might be better just to read the updated version of the readme