Skip to content

KEP-4639: Mark as implemented with disable-supported false#5960

Open
saschagrunert wants to merge 1 commit intokubernetes:masterfrom
saschagrunert:kep-4639-implemented
Open

KEP-4639: Mark as implemented with disable-supported false#5960
saschagrunert wants to merge 1 commit intokubernetes:masterfrom
saschagrunert:kep-4639-implemented

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 12, 2026 •
edited
Loading

Mark KEP-4639 as implemented with disable-supported set to false

Refers to: #4639

Reflects the stable graduation of OCI images as VolumeSource in v1.36.

@saschagrunert
KEP-4639: Mark as implemented with disable-supported false
df4d96d 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Mar 12, 2026
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2026
@saschagrunert saschagrunert mentioned this pull request Mar 12, 2026
Open
18 tasks
@saschagrunert
Copy link
Member Author

saschagrunert commented Mar 12, 2026

@kubernetes/sig-node-feature-requests PTAL

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 12, 2026
kannon92
kannon92 reviewed Mar 12, 2026
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2026
@kannon92
Copy link
Contributor

kannon92 commented Mar 12, 2026

/assign @haircommander

SergeyKanzhelev
SergeyKanzhelev approved these changes Mar 12, 2026
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

(Implementation history in readme can also be updated, but I never understood this duplication)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saschagrunert, SergeyKanzhelev
Once this PR has been reviewed and has the lgtm label, please ask for approval from haircommander. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lmktfy
Copy link
Member

lmktfy commented Mar 17, 2026

/hold

until the release has happened. Right?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2026
lmktfy
lmktfy reviewed Mar 17, 2026
View reviewed changes
keps/sig-node/4639-oci-volume-source/kep.yaml
- sig-node
- sig-storage
status: implementable
status: implemented
Copy link
Member

@lmktfy lmktfy Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to wait until the feature gate can no longer be set (for the current minor release)?

@saschagrunert
Copy link
Member Author

saschagrunert commented Mar 17, 2026

Yes, let's wait for 1.36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 kannon92 left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

+1 more reviewer

@lmktfy lmktfy lmktfy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kannon92 kannon92

@haircommander haircommander

@SergeyKanzhelev SergeyKanzhelev

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@saschagrunert @kannon92 @k8s-ci-robot @lmktfy @SergeyKanzhelev @haircommander