-
Notifications
You must be signed in to change notification settings - Fork 246
Make cloud controller manager image multi arch in bazel #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jakweg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @jakweg! |
|
Hi @jakweg. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| repository = "{repository_placeholder}", | ||
| ) | ||
|
|
||
| # Legacy single platform image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I authored the PR you referenced, we don't use bazel to build the images so you can remove this section.
|
Hey, Thanks for reaching out. I saw that we, internally at Google, still use this Bazel file - that's why I created the PR. Since you want to get rid of Bazel in the first place, maybe I should point the internal infrastructure to use the flow you've updated recently? WDYT @justinsb? |
|
Please point your internal build process to the new approach for the docker images, we'll be doing the same to the binaries as well |
PR #925 added support for multi architecture images of GCP CCM.
Google internal tools use bazel configuration in
cmd/cloud-controller-manager/BUILDwhich is only able to build single platform images.This PR updates BUILD file to be able to build multiplatform images as well while keeping compatibility with current pipelines.