-
Notifications
You must be signed in to change notification settings - Fork 246
Release shared lock after ensuring internal health check #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Release shared lock after ensuring internal health check #867
Conversation
|
Skipping CI for Draft Pull Request. |
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Because of the defer the shared resources mutex was locked even after the shared resource - health check - was provisioned. When provisioning multiple LBs, consequent ones would be waiting for the lock to be released, slowing down consequent ensure operations.
8d32fe8 to
edee3e8
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TortillaZHawaii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Because of the defer the shared resources mutex was locked even after the shared resource - health check - was provisioned. When provisioning multiple LBs, consequent ones would be waiting for the lock to be released, slowing down consequent ensure operations.