Skip to content

docs: replace sinker placeholder page with real component docs#622

Open
abdallhMoukdad wants to merge 1 commit intokubernetes-sigs:mainfrom
abdallhMoukdad:docs/sinker-page-495
Open

docs: replace sinker placeholder page with real component docs#622
abdallhMoukdad wants to merge 1 commit intokubernetes-sigs:mainfrom
abdallhMoukdad:docs/sinker-page-495

Conversation

@abdallhMoukdad
Copy link

@abdallhMoukdad abdallhMoukdad commented Feb 13, 2026

Summary

  • replace the placeholder sinker page with real component documentation
  • document what sinker cleans up and how config values affect behavior
  • add sinker config.yaml keys with defaults
  • add grouped CLI flag tables (sinker, config loading, kubernetes, instrumentation)
  • add operational notes (--dry-run=false in production and required permissions)

Fixes #495

@netlify
Copy link

netlify bot commented Feb 13, 2026

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 6a69598
🔍 Latest deploy log https://app.netlify.com/projects/k8s-prow/deploys/698f8eb11944b30008f2e1cc
😎 Deploy Preview https://deploy-preview-622--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested a review from matthyx February 13, 2026 20:50
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abdallhMoukdad
Once this PR has been reviewed and has the lgtm label, please assign matthyx for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from smg247 February 13, 2026 20:51
@k8s-ci-robot k8s-ci-robot added the area/documentation Issues or PRs related to documentation label Feb 13, 2026
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 13, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: abdallhMoukdad / name: abdallhMoukdad (6a69598)

@k8s-ci-robot
Copy link
Contributor

Welcome @abdallhMoukdad!

It looks like this is your first PR to kubernetes-sigs/prow 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/prow has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 13, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @abdallhMoukdad. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 13, 2026
@abdallhMoukdad
Copy link
Author

Hi @matthyx @smg247, CLA is signed now. Could one of you please run /ok-to-test? Thanks!

@matthyx
Copy link
Contributor

matthyx commented Feb 14, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

https://docs.prow.k8s.io/docs/components/core/sinker/ page is a placehoder

3 participants