deck: drop stale non-blocking presubmit contexts from PR status

[Pnkcaht]

What I did

• Updated Deck PR status rendering to build the context list strictly from current ProwJobs.
• GitHub contexts are now only used to enrich existing ProwJob entries.
• GitHub-only contexts without a corresponding ProwJob are dropped, preventing stale or renamed presubmit jobs from appearing in the PR UI.

Related issue

Fixes: #36399

What still needs to be done

• Redefine how Prow comments are rebuilt, so they are fully recomputed instead of delta-updated.
• Handle presubmit job renames explicitly, ensuring old job entries are removed from comments.
• Align expected /skip behavior with comment state reset semantics.

This was not addressed here because it is a larger behavioral change and needs agreement from the Prow team before implementation.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Pnkcaht
Once this PR has been reviewed and has the lgtm label, please assign michelle192837 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• cmd/deck/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for k8s-prow ready!

Name	Link
🔨 Latest commit	fe64702
🔍 Latest deploy log	https://app.netlify.com/projects/k8s-prow/deploys/69879e9af6849c000898124d
😎 Deploy Preview	https://deploy-preview-615--k8s-prow.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[k8s-ci-robot]

Welcome @Pnkcaht!

It looks like this is your first PR to kubernetes-sigs/prow 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/prow has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Pnkcaht. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kkauy]

Thanks for linking this to #36399 and working on the Deck-side cleanup.

Just to confirm: this addresses the stale non-blocking contexts in the PR UI, while the separate issues around prow comment delta-updates and /skip reset behavior remain open follow-ups, correct?

[Pnkcaht]

Thanks for linking this to #36399 and working on the Deck-side cleanup.

Just to confirm: this addresses the stale non-blocking contexts in the PR UI, while the separate issues around prow comment delta-updates and /skip reset behavior remain open follow-ups, correct?

This PR focuses specifically on the Deck-side cleanup by filtering out those stale contexts from the UI. The issues regarding Prow comment delta-updates and the /skip behavior are indeed separate and will remain as follow-ups :)
But there are still some things that need to be done, as I mentioned in the description.

[kkauy]

Thanks for the clarification.
Glad to see the Deck-side cleanup handled separately from the broader issues around Prow comment delta updates and /skip reset behavior. I’d be interested in helping with the follow-up work once the direction is clearer. Please let me know if there’s an existing discussion or preferred approach I should align with.

[Pnkcaht]

Thanks for the clarification.
Glad to see the Deck-side cleanup handled separately from the broader issues around Prow comment delta updates and /skip reset behavior. I’d be interested in helping with the follow-up work once the direction is clearer. Please let me know if there’s an existing discussion or preferred approach I should align with.

Sure @kkauy , as soon as this pull request is merged, I'll start the continuation and let you know there :)

[kkauy]

Sounds good, thanks!

I’ll keep an eye on this and would be happy to help with the follow-up once it’s merged.

[Pnkcaht]

Sounds good, thanks!

I’ll keep an eye on this and would be happy to help with the follow-up once it’s merged.

Sure, thank you for that

[ivankatliarchuk]

Am I correctly understand this

The PR title says "non-blocking presubmit contexts" but the change drops all GitHub-only contexts. If a PR has required status checks from non-Prow CI (GitHub Actions, external bots, etc.), they will silently disappear from Deck's PR status view.

No test files exist for getFullPRContext and none are added. The behavioral change is non-trivial and this function deserves at minimum a few unit tests covering:

• ProwJob-only context (no GitHub counterpart)
• GitHub-only context (should now be dropped)
• Matching pair with state mismatch → discrepancy populated
• Matching pair with state match → no discrepancy