Skip to content

Document opt-in namespace management for jobs #7890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PannagaRao wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Document opt-in namespace management for jobs #7890

PannagaRao wants to merge 2 commits into from

Conversation

@PannagaRao
Copy link
Contributor

@PannagaRao PannagaRao commented Nov 25, 2025

Signed-off-by: Pannaga Rao Bhoja Ramamanohara

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # #7534

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Nov 25, 2025
@netlify
Copy link

netlify bot commented Nov 25, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 96f701b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/693090d7fd0bac0008698da6

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 25, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 25, 2025

Hi @PannagaRao. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2025
@PannagaRao PannagaRao changed the title Document opt-in namespace management for jobs WIPDocument opt-in namespace management for jobs Nov 25, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 25, 2025
@PannagaRao PannagaRao changed the title WIPDocument opt-in namespace management for jobs WIP: Document opt-in namespace management for jobs Nov 25, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2025
kannon92
kannon92 suggested changes Nov 25, 2025
View reviewed changes
@kannon92
Copy link
Contributor

kannon92 commented Nov 25, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 25, 2025
@PannagaRao
Document opt-in namespace management for jobs
93aa04e 
Signed-off-by: Pannaga Rao Bhoja Ramamanohara
@PannagaRao PannagaRao force-pushed the doc-managedJobsNamespaceSelector branch 2 times, most recently from bd1e27f to 592257b Compare November 25, 2025 18:21
@PannagaRao PannagaRao changed the title WIP: Document opt-in namespace management for jobs Document opt-in namespace management for jobs Nov 26, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2025
kannon92
kannon92 reviewed Nov 26, 2025
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @mimowo @tenzen-y

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 26, 2025

LGTM label has been added.

Git tree hash: 2c9d56b7989603fe100d480059aac844d42b210e

@kannon92
Copy link
Contributor

kannon92 commented Nov 26, 2025

Idk why I can't view the preview for the site.

tenzen-y
tenzen-y reviewed Nov 26, 2025
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this documentation.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PannagaRao
Once this PR has been reviewed and has the lgtm label, please ask for approval from mimowo. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PannagaRao PannagaRao force-pushed the doc-managedJobsNamespaceSelector branch from bef2cce to 318061d Compare November 26, 2025 18:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2025
kannon92
kannon92 reviewed Dec 2, 2025
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @tenzen-y @mimowo

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2025

LGTM label has been added.

Git tree hash: 748978fc777f05afaf4d4f4bec91e947264d49fa

mimowo
mimowo reviewed Dec 2, 2025
View reviewed changes
site/content/en/docs/tasks/manage/enforce_job_management/opt_in_namespace_management.md Outdated

### Step 3: Enable the Feature Gate

This step is optional if you're using Kueue v0.15 or later, as the `ManagedJobsNamespaceSelectorAlwaysRespected` feature gate is enabled by default. If you're using an older version of Kueue, you need to explicitly enable this feature gate. See [Feature Gate Details](#feature-gate-details) for configuration instructions.
Copy link
Contributor

@mimowo mimowo Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reference https://kueue.sigs.k8s.io/docs/installation/#feature-gates-for-alpha-and-beta-features instead, and make sure the history for the feature gate is there.

Copy link
Contributor Author

@PannagaRao PannagaRao Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the reference to the doc and removed the section that explicitly explained the status of the feature gate. PTAL if it looks okay now.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 3, 2025

New changes are detected. LGTM label has been removed.

@PannagaRao
Address review comments
96f701b 
Signed-off-by: Pannaga Rao Bhoja Ramamanohara
@PannagaRao PannagaRao force-pushed the doc-managedJobsNamespaceSelector branch from 4cc2734 to 96f701b Compare December 3, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PBundyra PBundyra Awaiting requested review from PBundyra

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@kannon92 kannon92 Awaiting requested review from kannon92

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@kannon92 kannon92

@mimowo mimowo

@tenzen-y tenzen-y

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PannagaRao @k8s-ci-robot @kannon92 @mimowo @tenzen-y