Skip to content

Add CI check for broken links#13040

Open
onasser1 wants to merge 2 commits intokubernetes-sigs:masterfrom
onasser1:check-broken-links
Open

Add CI check for broken links#13040
onasser1 wants to merge 2 commits intokubernetes-sigs:masterfrom
onasser1:check-broken-links

Conversation

@onasser1
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR uses lychee checker to scan links in docs directory in the codebase to detect broken/dead links during CI checks.
Which issue(s) this PR fixes:
Fixes #12104

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 23, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: onasser1
Once this PR has been reviewed and has the lgtm label, please assign mzaian for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 23, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @onasser1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 23, 2026
@onasser1
Copy link
Author

Hi @yankay 👋🏻 can you review this PR if you've capacity please?

@VannTen
Copy link
Contributor

VannTen commented Feb 23, 2026

This doesn't add any check in CI from what I can see ?
(Fixing broken link is welcome, but maybe you're missing another commit which wasn't pushed ?)

@onasser1
Copy link
Author

This doesn't add any check in CI from what I can see ? (Fixing broken link is welcome, but maybe you're missing another commit which wasn't pushed ?)

Yup sorry, I forgot to push the workflow commit.

@yankay
Copy link
Member

yankay commented Feb 24, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2026
@onasser1
Copy link
Author

/ok-to-test

seems like it's a system failure. can we re-test or I've to change something?

https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/13235070821

@tico88612
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI check for broken Link

5 participants